JitDump and other minor improvements #96933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make `DOTNET_JitDisasmAssemblies` apply to `JitDump` as well. 2. Fix JitDump of `gsParamsToShadows`: it calls `fgMorphTree` which requires `compCurBB` to be set, but apparently only for JitDump. 3. Various typos and formatting nits
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
|
|
@jakobbotsch PTAL |
jakobbotsch
approved these changes
Jan 14, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
1. Make `DOTNET_JitDisasmAssemblies` apply to `JitDump` as well. 2. Fix JitDump of `gsParamsToShadows`: it calls `fgMorphTree` which requires `compCurBB` to be set, but apparently only for JitDump. 3. Various typos and formatting nits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOTNET_JitDisasmAssembliesapply toJitDumpas well.gsParamsToShadows: it callsfgMorphTreewhich requirescompCurBBto be set, but apparently only for JitDump.