Skip to content

Comment out assert to workaround codegen bug #96877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Jan 12, 2024

Workaround for #96876

@ghost ghost assigned stephentoub Jan 12, 2024
@ghost
Copy link

ghost commented Jan 12, 2024

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #96773
Fixes #96876

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Runtime.InteropServices

Milestone: -

@jkotas jkotas force-pushed the revert-96773-shrinkasspan branch from ca37d98 to 0408456 Compare January 13, 2024 00:00
@jkotas jkotas changed the title Revert "Reduce asm size of CollectionsMarshal.AsSpan" Comment out assert to workaround codegen bug Jan 13, 2024
@stephentoub stephentoub merged commit fb8c77f into main Jan 13, 2024
@stephentoub stephentoub deleted the revert-96773-shrinkasspan branch January 13, 2024 04:18
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants