Skip to content

[release/8.0-staging] [browser] Fix debug URL in lauchSettings.json in wasmbrowser template #95418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 29, 2023

Backport of #95392 to release/8.0-staging

/cc @maraf

Customer Impact

Users creating apps from wasmbrowser template are able to start the application with debugging from Visual Studio
Fixes user reported issue

Testing

Manually

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 29, 2023
@maraf maraf self-assigned this Nov 29, 2023
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 29, 2023
@maraf maraf added this to the 8.0.x milestone Nov 29, 2023
@ghost
Copy link

ghost commented Nov 29, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #95392 to release/8.0-staging

/cc @maraf

Customer Impact

Users creating apps from wasmbrowser template are able to start the application with debugging from Visual Studio

Testing

Manul

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: maraf
Labels:

arch-wasm, area-Build-mono, os-browser

Milestone: -

@maraf maraf added the Servicing-consider Issue for next servicing release review label Nov 29, 2023
@maraf
Copy link
Member

maraf commented Dec 5, 2023

Approved via email

@maraf maraf added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 5, 2023
@akoeplinger akoeplinger modified the milestones: 8.0.x, 8.0.2 Dec 6, 2023
@maraf maraf merged commit a78ff1a into release/8.0-staging Dec 11, 2023
@maraf maraf deleted the backport/pr-95392-to-release/8.0-staging branch December 11, 2023 11:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants