Skip to content

Correct time zone name creation when generated lazily. #95304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Nov 28, 2023

#95213

This addresses the regression introduced in .NET 8.0 #88368, where creating a TimeZoneInfo object using a Windows Id on Linux/Mac resulted in empty strings for Standard, Daylight, and display names.

@ghost ghost added the area-System.DateTime label Nov 28, 2023
@ghost ghost assigned tarekgh Nov 28, 2023
@tarekgh tarekgh requested a review from mdh1418 November 28, 2023 00:11
@ghost
Copy link

ghost commented Nov 28, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

#95213

This addresses the regression introduced in .NET 8.0, where creating a TimeZoneInfo object using a Windows Id on Linux/Mac resulted in empty strings for Standard, Daylight, and display names.

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.DateTime

Milestone: -

@tarekgh tarekgh added this to the 9.0.0 milestone Nov 28, 2023
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thanks for the catch!

@tarekgh tarekgh merged commit 14c04f9 into dotnet:main Nov 28, 2023
@tarekgh tarekgh deleted the FixTimeZonesNames branch November 28, 2023 22:25
@tarekgh
Copy link
Member Author

tarekgh commented Nov 28, 2023

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7025334861

@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants