[release/8.0-staging] Improve the hash function used in the InstMethodHashTable
#95285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Instead of using the TypeDef token of the MethodTable, use the TypeHandle pointer instead. This is both faster to compute, and is more unique, as the TypeDef token could be shared across multiple types in different assemblies, and if the type is generic itself, it could be shared across multiple different instantiations of the type. Improves the benchmark mentioned in isseu #94936 such that the cost is about 24 seconds, and the time in spent is spent almost entirely in the JIT, as should be expected. Fixes #94936
ghost
added
the
davidwrighton
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Nov 27, 2023
AaronRobinsonMSFT
approved these changes
Nov 27, 2023
JulieLeeMSFT
added
Servicing-approved
|
CC @carlossanlop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #94938 to release/8.0-staging
/cc @davidwrighton
Customer Impact
This dramatically improves the performance of compiling async functions in an application which has an extreme number of assemblies which are very similarly structured. See issue #94936.
This is not a regression.
Testing
Manual testing of affected scenario + standard broad CI testing
Risk
Low. This only changes a hash function, to include more entropy, and it does so in a way which touches less memory, so it should also be faster as well.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.