Skip to content

Revert "[release/8.0] Downgrade 6 & 7 per tactics" #95075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossanlop merged 1 commit into from
Nov 21, 2023
Merged

Revert "[release/8.0] Downgrade 6 & 7 per tactics" #95075

carlossanlop merged 1 commit into from
Nov 21, 2023

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Nov 21, 2023

Reverts #94863

@ghost ghost assigned mmitche Nov 21, 2023
@mmitche mmitche requested a review from carlossanlop November 21, 2023 18:14
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 21, 2023
carlossanlop
carlossanlop approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @lewing @steveisok

@carlossanlop carlossanlop added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 21, 2023
@ghost
Copy link

ghost commented Nov 21, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #94863

Author: mmitche
Assignees: mmitche
Labels:

area-Infrastructure
Milestone: -

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Nov 21, 2023
@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 21, 2023

Please wait for @lewing to confirm this is all we need.

@steveisok steveisok self-requested a review November 21, 2023 18:58
@steveisok
Copy link
Member

steveisok commented Nov 21, 2023

EMSDK needs the same kind of change.

@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 21, 2023

EMSDK needs the same kind of change.

@steveisok I assume you mean a change in the dotnet/emsdk repo, as opposed to an additional change here in runtime that affects emsdk?

@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 21, 2023

Whatever the case, I'll merge this and anything extra can be addressed in a separate PR, since the CI here is about to finish.

@carlossanlop carlossanlop added this to the 8.0.1 milestone Nov 21, 2023
@carlossanlop carlossanlop merged commit 4609a7b into release/8.0 Nov 21, 2023
@carlossanlop carlossanlop deleted the revert-94863-downgrade-downlevel branch November 21, 2023 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mmitche mmitche

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

None yet

Milestone

8.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mmitche @carlossanlop @steveisok