Skip to content

Replace LowLevelLock with Lock #94991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2023
Merged

Replace LowLevelLock with Lock #94991

merged 1 commit into from
Nov 21, 2023

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Nov 20, 2023

Context: #94873 (comment)

Cc @dotnet/ilc-contrib

@ghost
Copy link

ghost commented Nov 20, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Context: #94873 (comment)

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@MichalStrehovsky MichalStrehovsky mentioned this pull request Nov 20, 2023
Merged
VSadov
VSadov approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichalStrehovsky MichalStrehovsky merged commit 3b61ad9 into main Nov 21, 2023
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch November 21, 2023 07:46
@jkotas
Copy link
Member

jkotas commented Nov 21, 2023

I do not think that this is a good change, and it should be reverted. This change can lead to reentrancy crashes if user code overrides SynchronizationContext.Wait and the override attempts to create System.RuntimeType instance (e.g. by calling `object.GetType()).

#94873 (comment) has more context.

MichalStrehovsky added a commit that referenced this pull request Nov 21, 2023
@MichalStrehovsky
Revert "Replace LowLevelLock with Lock (#94991)"
fd5d7a0 
This reverts commit 3b61ad9.
@MichalStrehovsky MichalStrehovsky mentioned this pull request Nov 21, 2023
Merged
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Nov 21, 2023

I do not think that this is a good change, and it should be reverted. This change can lead to reentrancy crashes if user code overrides SynchronizationContext.Wait and the override attempts to create System.RuntimeType instance (e.g. by calling `object.GetType()).

#94873 (comment) has more context.

Revert in #95071.

stephentoub pushed a commit that referenced this pull request Nov 21, 2023
@MichalStrehovsky
Revert "Replace LowLevelLock with Lock (#94991)" (#95071)
1050695 
This reverts commit 3b61ad9.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VSadov VSadov VSadov approved these changes

Assignees

@MichalStrehovsky MichalStrehovsky

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichalStrehovsky @jkotas @VSadov