Skip to content

Fix comment typo in jithelp.asm #94956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fix comment typo in jithelp.asm #94956

merged 3 commits into from
Nov 20, 2023

Conversation

ericmutta
Copy link
Contributor

The sentence:

it is imperative that the addresses of of the values...

Should read:

it is imperative that the addresses of the values

PS: Came across this will trying to figure out how the JIT transitions into native code after generating it from IL (I still haven't figured it all out so if there any pointers for this particular topic, I would appreciate some guidance 🙏).

The sentence:

> it is imperative that the addresses **of of** the values...

Should read:

> it is imperative that the addresses **of** the values
@jkotas
Copy link
Member

jkotas commented Nov 19, 2023

The same typo is in multiple files:

src\coreclr\vm\amd64\JitHelpers_FastWriteBarriers.asm(34):; it is imperative that the addresses of of the values that we overwrite
src\coreclr\vm\i386\jithelp.asm(824):; it is imperative that the addresses of of the values that we overwrite
src\coreclr\vm\i386\jithelp.S(682)://  it is imperative that the addresses of of the values that we overwrite

Could you please fix all of them?

The sentence:

> it is imperative that the addresses **of of** the values...

Should read:

> it is imperative that the addresses **of** the values
The sentence:

> it is imperative that the addresses **of of** the values...

Should read:

> it is imperative that the addresses **of** the values
@ericmutta
Copy link
Contributor Author

@jkotas thanks for following up and spotting the extra typos. I have pushed more commits to fix them 👍

PS: if you can, please point me to the parts of the CLR where a method's IL is compiled to native code, then control is transferred to that native code.

@jkotas
Copy link
Member

jkotas commented Nov 20, 2023

if you can, please point me to the parts of the CLR where a method's IL is compiled to native code, then control is transferred to that native code.

I think you are looking for PrestubWorker method in https://github.com/dotnet/runtime/blob/main/src/coreclr/vm/prestub.cpp#L2341. This method is called by small piece of assembly code. This assembly code transfers the control to the native code address returned by PrestubWorker . This is Windows x64 version of that assembly code: https://github.com/dotnet/runtime/blob/main/src/coreclr/vm/amd64/ThePreStubAMD64.asm

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 40d9bd2 into dotnet:main Nov 20, 2023
@ericmutta ericmutta deleted the patch-1 branch November 20, 2023 12:57
@ericmutta
Copy link
Contributor Author

Many thanks @jkotas, that's exactly what I was looking for 👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants