Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements more advanced ILLink/ILCompiler analysis for Type.GetMember #94879

Closed
wants to merge 20 commits into from
Closed

Implements more advanced ILLink/ILCompiler analysis for Type.GetMember #94879

wants to merge 20 commits into from

Commits on Nov 16, 2023

  1. Implement masking based on MemberTypes 

    - Implements masking the required member types based on the MemberTypes parameter
    @hamarb123
    hamarb123 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ced1292 View commit details
    Browse the repository at this point in the history

  2. Update HandleCallAction.cs

    @hamarb123
    hamarb123 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d0df383 View commit details
    Browse the repository at this point in the history

  3. Implement matching by name 

    - Matching by name is implemented here, including logic to handle the prefix name lookup scheme of GetMember & special handling for constructors
    @hamarb123
    hamarb123 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    65a5a1c View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge branch 'main' into main7

    @hamarb123
    hamarb123 authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    74e87f2 View commit details
    Browse the repository at this point in the history

  2. Implement methods in other files

    @hamarb123
    hamarb123 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b15124a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main7' of https://github.com/hamarb123/runtime into main7

    @hamarb123
    hamarb123 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f9c437f View commit details
    Browse the repository at this point in the history

  4. Fix compile errors

    @hamarb123
    hamarb123 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b3c8d5f View commit details
    Browse the repository at this point in the history

  5. Fix some compile errors and spacing 

    - We use EndsWith(string) because some platforms don't have the char overload
    @hamarb123
    hamarb123 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8439ea2 View commit details
    Browse the repository at this point in the history

  6. Update HandleCallAction.cs

    @hamarb123
    hamarb123 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    21e41b0 View commit details
    Browse the repository at this point in the history

  7. Update HandleCallAction.cs

    @hamarb123
    hamarb123 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3093fe5 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Add some unit tests & fix some code 

    - Update the `[Kept]` attributes on the unit tests to reflect what we should now expect to be kept
- Add some more unit tests
- Fix missing `| BindingFlags.Static` for the default binding flags
    @hamarb123
    hamarb123 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    1053805 View commit details
    Browse the repository at this point in the history

  2. Fix typo & move ctors to top

    @hamarb123
    hamarb123 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    02b6c45 View commit details
    Browse the repository at this point in the history

  3. Update MemberUsedViaReflection.cs

    @hamarb123
    hamarb123 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    40044cd View commit details
    Browse the repository at this point in the history

  4. Update MemberUsedViaReflection.cs

    @hamarb123
    hamarb123 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    0646bb1 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Update some [Kept] attributes 

    - And add another .IsEmpty check like similar APIs have
    @hamarb123
    hamarb123 committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    b665d99 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Apply some feedback (incomplete) 

    - Remove prefix versions of APIs
- Remove ignoring of .Custom
- Add missing space
    @hamarb123
    hamarb123 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    dd6379b View commit details
    Browse the repository at this point in the history

  2. Update HandleCallAction.cs 

    - Remove remaining prefix code
- Don't call AddReturnValue
    @hamarb123
    hamarb123 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ec45c87 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main7

    @hamarb123
    hamarb123 authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ac1066a View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Update HandleCallAction.cs 

    - Implement feedback for .ctor
- Remove calls to `AddReturnValue (MultiValueLattice.Top);`, since this returns an array
    @hamarb123
    hamarb123 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4d8ccf3 View commit details
    Browse the repository at this point in the history

  2. Update HandleCallAction.cs

    @hamarb123
    hamarb123 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f8cfd86 View commit details
    Browse the repository at this point in the history