[release/8.0-staging] Fix for a stress crash in ComAwareWeakReferenceNative::HasInteropInfo #94649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…yncblock is gone.
jkotas
approved these changes
Nov 12, 2023
|
Friendly reminder: If you'd like this to be included in the December release, please merge it before Tuesday November 14th EOD (Code Complete). |
jeffschwMSFT
approved these changes
Nov 14, 2023
AaronRobinsonMSFT
approved these changes
Nov 14, 2023
AaronRobinsonMSFT
added
Servicing-consider
|
@AaronRobinsonMSFT @jeffschwMSFT did this end up getting Tactics approval? Today is code complete. |
@carlossanlop for January? |
No, it's code complete for December: https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/38691/December-2023 |
|
I'm starting the flow from staging to internal now, so the branches are closed. This will have to wait until the January release. |
leecow
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #94643 to release/8.0-staging
/cc @VSadov
Customer Impact
Fixes: #94579
The issue was reported by an external customer. In rare cases when creating a weak reference instance an application may crash with ExecutionEngineException in the runtime while probing for COM interop info.
The repro is a fairly large WinForms app (paint.net)
When run with
GCStress=2the crash is nearly 100% certain.Testing
Regular testing.
Manually validated that the customer repro no longer causes EE crashes. That includes running it under
GCStress=2Risk
Low. The fix is adding a missing null-check where we had an assert.
Turns out the asserted condition may not hold when racing with GC and must be handled.