Skip to content

[browser] allow zero as debug level #94456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

[browser] allow zero as debug level #94456

merged 1 commit into from
Nov 7, 2023

Conversation

pavelsavara
Copy link
Member

Fixes #94238

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Nov 7, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Nov 7, 2023
@pavelsavara pavelsavara requested a review from maraf November 7, 2023 12:17
@pavelsavara pavelsavara self-assigned this Nov 7, 2023
@pavelsavara pavelsavara requested review from lewing and kg as code owners November 7, 2023 12:17
@ghost
Copy link

ghost commented Nov 7, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #94238

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara merged commit 5de6ca4 into dotnet:main Nov 7, 2023
@pavelsavara pavelsavara deleted the browser_withDebugging branch November 7, 2023 14:25
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[WASM] DotnetHostBuilder withDebugging does not accept a value of 0
2 participants
@pavelsavara @maraf