Skip to content

Interlocked intrinsic improvements #93821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kunalspathak merged 2 commits into from
Oct 27, 2023
Merged

Interlocked intrinsic improvements #93821

kunalspathak merged 2 commits into from
Oct 27, 2023

Conversation

@MichalPetryka
Copy link
Contributor

@MichalPetryka MichalPetryka commented Oct 21, 2023

Allows expansion for ref type intrinsics with FOH objects.

Marks unsinged overloads with [Intrinsic] to make them not impact codegen.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Oct 21, 2023
@MichalPetryka
Copy link
Contributor Author

MichalPetryka commented Oct 21, 2023

cc @EgorBo

@ghost
Copy link

ghost commented Oct 21, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Allows expansion for ref type intrinsics with FOH objects.

Marks unsinged overloads with [Intrinsic] to make them not impact codegen.

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@MichalPetryka
Copy link
Contributor Author

MichalPetryka commented Oct 21, 2023

@MihuBot

@MihuBot MihuBot mentioned this pull request Oct 21, 2023
Open
This was referenced Oct 22, 2023
Closed
Closed
Closed
EgorBo
EgorBo approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kunalspathak kunalspathak merged commit aae9497 into dotnet:main Oct 27, 2023
liveans pushed a commit to liveans/dotnet-runtime that referenced this pull request Nov 9, 2023
@MichalPetryka @liveans
Interlocked intrinsic improvements (dotnet#93821)
b4c165d 
* Interlocked intrinsic improvements

* Format
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalPetryka @EgorBo @kunalspathak