Skip to content

SPMI: Fix wrong SPMI replay result check #93062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Oct 5, 2023

Fix a bug introduced in #92824 that would cause SPMI to not show replay failures.

Fix a bug introduced in dotnet#92824 that would SPMI to not show replay
failures.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 5, 2023
@ghost ghost assigned jakobbotsch Oct 5, 2023
@ghost
Copy link

ghost commented Oct 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix a bug introduced in #92824 that would SPMI to not show replay failures.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib

@jakobbotsch jakobbotsch merged commit 0b4ec5a into dotnet:main Oct 5, 2023
@jakobbotsch jakobbotsch deleted the fix-superpmi-on-failures branch October 5, 2023 15:15
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants