Skip to content

[release/7.0-staging] CI: runtime-wasm-perf: disable for PRs #92978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

[release/7.0-staging] CI: runtime-wasm-perf: disable for PRs #92978

merged 1 commit into from
Oct 4, 2023

Conversation

radical
Copy link
Member

@radical radical commented Oct 3, 2023 •
edited
Loading

Since we have runtime-wasm-perf enabled for PRs now, it needs a corresponding pr: none in the yml to disable it for this branch.

@radical radical added the arch-wasm WebAssembly architecture label Oct 3, 2023
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 3, 2023
@ghost ghost assigned radical Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical changed the title CI: runtime-wasm-perf: disable for PRs [release/7.0] CI: runtime-wasm-perf: disable for PRs Oct 3, 2023
@radical radical mentioned this pull request Oct 4, 2023
Merged
@ghost
Copy link

ghost commented Oct 4, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Since we have runtime-wasm-perf enabled for PRs now, it needs a corresponding pr: none in the yml to disable it for this branch.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono, needs-area-label
Milestone: -

@radical radical added Servicing-consider Issue for next servicing release review and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 4, 2023
carlossanlop
carlossanlop approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell mode. Approved.

@carlossanlop
Copy link
Contributor

@radical can you please target release/7.0-staging instead?

@radical radical changed the base branch from release/7.0 to release/7.0-staging October 4, 2023 00:25
@radical radical changed the title [release/7.0] CI: runtime-wasm-perf: disable for PRs [release/7.0-staging] CI: runtime-wasm-perf: disable for PRs Oct 4, 2023
@radical
Copy link
Member Author

radical commented Oct 4, 2023

@radical can you please target release/7.0-staging instead?

Done. These two PRs can be merged without waiting for CI checks because the change will not be exercised by them.

@radical radical force-pushed the runtime-wasm-perf-triggers-7 branch from 3ee561f to f1df565 Compare October 4, 2023 00:26
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 4, 2023
@carlossanlop carlossanlop merged commit 89d99c9 into dotnet:release/7.0-staging Oct 4, 2023
@build-analysis build-analysis bot mentioned this pull request Oct 4, 2023
Open
This was referenced Oct 12, 2023
Merged
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

@dougbu dougbu Awaiting requested review from dougbu

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @carlossanlop