-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[browser] Fix SIMD+EH check #92348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Fix SIMD+EH check #92348
Conversation
… ready (onRuntimeInitializedAsync)
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
So, this always failed on browsers that didn't support SIMD/EH, even when SIMD was disabled in the build? Can we test this with chrome/v8? |
Exactly.
If we install Chrome 85 or Firefox 88, we can test it. I can look into it in a separate PR. |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6265063819 |
/backport to release/8.0-rc2 |
Started backporting to release/8.0-rc2: https://github.com/dotnet/runtime/actions/runs/6267696867 |
closed in favor of #92439 |
linkerWasmEnableSIMD
andlinkerWasmEnableEH
used inconfigureRuntimeStartup
to check support for these features always had the default (true
) value. Throwing assert error even when SIMD and EH was disabled for build.cwraps.mono_wasm_abort
fromruntimeHelpers.abort
only after cwraps are ready (onRuntimeInitializedAsync
).