[browser] cleanup for emscripten main in a web worker by pavelsavara · Pull Request #92280 · dotnet/runtime

pavelsavara · 2023-09-19T14:50:36Z

close the console forwarding socket
move virtualWorkingDirectory and applicationArguments to MonoConfig
propagate ENVIRONMENT_IS_WORKER which is wrong after starting on web worker
fix how ENVIRONMENT_IS_WEB_WORKER and others are detected
unified the detection in test-main.js
introduce globalThis.dotnetSideCar for such detection
eliminate direct window and navigator usage

ghost · 2023-09-19T14:50:46Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`, `os-browser`
Milestone:	-

pavelsavara · 2023-09-19T21:12:06Z

/azp run runtime-wasm

azure-pipelines · 2023-09-19T21:12:16Z

Azure Pipelines successfully started running 1 pipeline(s).

…elsavara/runtime into browser_close_console_socket

src/mono/wasm/runtime/dotnet.d.ts

src/mono/wasm/runtime/globals.ts

src/mono/wasm/runtime/loader/globals.ts

src/mono/wasm/runtime/loader/icu.ts

src/mono/wasm/runtime/loader/run.ts

src/mono/wasm/runtime/startup.ts

src/mono/wasm/test-main.js

kg

LGTM though I'm not an expert on some pieces of it

close the socket

fc7f74f

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Sep 19, 2023

pavelsavara requested a review from maraf September 19, 2023 14:50

pavelsavara self-assigned this Sep 19, 2023

cleanup before side car

ec663f6

pavelsavara changed the title ~~[browser] close the console forwarding socket~~ [browser] cleanup for emscripten main in a web worker Sep 19, 2023

This was referenced Sep 20, 2023

Tracking issue for CI build timeouts #76454

Closed

[wasm][debugger] Debugger tests disabled #89409

Open

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Closed

fix

5b8a520

This comment was marked as outdated.

Sign in to view

pavelsavara and others added 2 commits September 21, 2023 17:18

fix

04997c3

cwd

af741db

pavelsavara added 3 commits September 22, 2023 12:54

fix

c895d74

Merge branch 'browser_close_console_socket' of https://github.com/pav…

8b71650

…elsavara/runtime into browser_close_console_socket

Merge branch 'main' into browser_close_console_socket

22cfb83

build-analysis bot mentioned this pull request Sep 22, 2023

[invalid][mono] System.IO.IsolatedStorage test failures on MacCatalyst #92468

Closed

6 tasks

pavelsavara marked this pull request as ready for review September 22, 2023 12:41

pavelsavara requested review from kg and lewing as code owners September 22, 2023 12:41