Skip to content

[wasm][debugger] Add tests for indexing by object schema #92268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2023
Merged

[wasm][debugger] Add tests for indexing by object schema #92268

merged 2 commits into from
Sep 20, 2023

Conversation

ilonatommy
Copy link
Member

Fixes partially #77536.

  • Added test for indexing by object Indexer: passes without code changes.

Out of scope:

  • Indexing with value type and array. Work is ongoing. The original issue will be edited to describe missing features and problems with implementations.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 19, 2023
@ghost ghost assigned ilonatommy Sep 19, 2023
@ghost
Copy link

ghost commented Sep 19, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes partially #77536.

  • Added test for indexing by object Indexer: passes without code changes.

Out of scope:

  • Indexing with value type and array. Work is ongoing. The original issue will be edited to describe missing features and problems with implementations.
Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy mentioned this pull request Jul 11, 2023
Closed
3 tasks
@build-analysis build-analysis bot mentioned this pull request Sep 19, 2023
Closed
@thaystg
Copy link
Member

thaystg commented Sep 19, 2023

Hum, you added new lines to the test, it looks like it broke other 2 tests:
image

@radical radical changed the title [wasm][debugger] Support indexing by object schema [wasm][debugger] Add tests for indexing by object schema Sep 19, 2023
@ilonatommy ilonatommy merged commit 901f780 into dotnet:main Sep 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thaystg thaystg thaystg approved these changes

@radical radical Awaiting requested review from radical

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilonatommy @thaystg