Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Numerics and Tensors backport #92245

Merged
merged 9 commits into from
Sep 19, 2023
Merged

[release/8.0] Numerics and Tensors backport #92245

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
30e2d6b
added Bcl.Numerics
michaelgsharp Sep 13, 2023
4d23e8c
Adding a naive implementation of various primitive tensor operations …
tannergooding Sep 5, 2023
25bc2ad
Start vectorizing TensorPrimitives (#91596)
stephentoub Sep 7, 2023
96ba8c1
6 more naive methods for Tensor Primitives. (#92142)
michaelgsharp Sep 16, 2023
6eb4ed5
Add remaining set of TensorPrimitives APIs for .NET 8 (#92154)
stephentoub Sep 16, 2023
fa6c295
Fix TensorPrimitives.CosineSimilarity to use vectorized implementatio…
stephentoub Sep 18, 2023
441a81a
Fixed duplicated code from merge.
michaelgsharp Sep 18, 2023
55726fa
New Microsoft.BCL.Numerics package (#91074)
michaelgsharp Aug 25, 2023
8a95ce5
Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFro…
tmds Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix TensorPrimitives.CosineSimilarity to use vectorized implementatio… 
…ns (#92204)
  • Loading branch information
@stephentoub @michaelgsharp
stephentoub authored and michaelgsharp committed Sep 18, 2023
commit fa6c2951a52c2a74bb956aa24340e97fde6c19fb
13 changes: 1 addition & 12 deletions src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,18 +271,7 @@ public static float CosineSimilarity(ReadOnlySpan<float> x, ReadOnlySpan<float>
ThrowHelper.ThrowArgument_SpansMustHaveSameLength();
}

float dotprod = 0f;
float magx = 0f;
float magy = 0f;

for (int i = 0; i < x.Length; i++)
{
dotprod += x[i] * y[i];
magx += x[i] * x[i];
magy += y[i] * y[i];
}

return dotprod / (MathF.Sqrt(magx) * MathF.Sqrt(magy));
return CosineSimilarityCore(x, y);
}

/// <summary>
Expand Down