Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light up BitArray APIs with Vector512 code path #91903

Merged
merged 13 commits into from
Sep 21, 2023
Merged

Light up BitArray APIs with Vector512 code path #91903

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
645840f
Upgrading And, OR, XOR, NOT and CopyTo using Vector512
khushal1996 Aug 2, 2023
ebb7fda
making m_array private again
khushal1996 Aug 2, 2023
ac56638
adding test for AVX512 and Making sure we are shifting the bits corre…
khushal1996 Aug 2, 2023
ddbfa25
Changing BitArray.CopyTo for Bool Array using Avx512BW
khushal1996 Aug 3, 2023
8e93d2e
Optimizing the code further and avoiding fallback to smaller size onc…
khushal1996 Aug 7, 2023
5defff2
Upgrading And, OR, XOR, NOT and CopyTo using Vector512
khushal1996 Aug 2, 2023
63160be
making m_array private again
khushal1996 Aug 2, 2023
e439e33
Changing BitArray.CopyTo for Bool Array using Avx512BW
khushal1996 Aug 3, 2023
37d5b66
Optimizing the code further and avoiding fallback to smaller size onc…
khushal1996 Aug 7, 2023
3911c95
reverting the wrong test case
khushal1996 Sep 11, 2023
56793f5
converting int to uint and tghen to ulong for zero extension
khushal1996 Sep 13, 2023
25a3b8c
Upgrading the BitArray(bool[]) API with Vector512 and making the sugg…
khushal1996 Sep 13, 2023
1e4e83f
organising imports
khushal1996 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding test for AVX512 and Making sure we are shifting the bits corre… 
…ctly
  • Loading branch information
@khushal1996
khushal1996 committed Sep 11, 2023
commit ac56638c8b57f151c03c946b6343c599ab49b194
2 changes: 1 addition & 1 deletion src/libraries/System.Collections/src/System/Collections/BitArray.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ public unsafe void CopyTo(Array array, int index)
{
for (; (i + Vector512ByteCount) <= (uint)m_length; i += Vector512ByteCount)
{
long bits = m_array[i / (uint)BitsPerInt32] + m_array[(i / (uint)BitsPerInt32) + 1];
long bits = m_array[i / (uint)BitsPerInt32] + (m_array[(i / (uint)BitsPerInt32) + 1] << BitsPerInt32);
Vector512<long> scalar = Vector512.Create(bits);
Vector512<byte> shuffled = Vector512.Shuffle(scalar.AsByte(), shuffleMask);
Vector512<byte> extracted = Avx512F.And(shuffled, bitMask);
Expand Down
6 changes: 5 additions & 1 deletion src/libraries/System.Collections/tests/BitArray/BitArray_GetSetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,11 +353,13 @@ public static void CopyToByteArray()
[Fact]
public static void CopyToBoolArray()
{
for (int size = 4; size < 100; size++)
for (int size = 10000; size < 10100; size++)
{
var bitArray = new BitArray(size);
bitArray[1] = true;
bitArray[3] = true;
bitArray[31] = true;
bitArray[34] = true;

for (int i = 0; i < 100; i++)
{
Expand All @@ -366,6 +368,8 @@ public static void CopyToBoolArray()

expectedOutput[i + 1] = true;
expectedOutput[i + 3] = true;
expectedOutput[i + 31] = true;
expectedOutput[i + 34] = true;
bitArray.CopyTo(actualOutput, i);

Assert.Equal(expectedOutput, actualOutput);
Expand Down