[mono] Unaligned read/write only when NO_UNALIGNED_ACCESS is set #91813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
filipnavara
reviewed
Sep 8, 2023
matouskozak
changed the title
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matouskozak
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
This was referenced Sep 22, 2023
matouskozak
changed the title
6 tasks
vargaz
approved these changes
Sep 25, 2023
|
What change caused the regression ? |
It was introduced in #89364 by changing |
|
The failures seem unrelated, and all can be found on main (e.g. bbe5c66) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using unaligned read code path only when
NO_UNALIGNED_ACCESSis set. Otherwise emit regular memory load (EMIT_NEW_LOAD_MEMBASE_TYPE) without usingmemcpy.Edit: Increased the scope of the change to both load/store operations. When CPU supports unaligned memory access (
NO_UNALIGNED_ACCESSis not set) we let CPU handle the unaligned load/store operation rather than handling it ourselves.Locally confirmed that it fixes
Perf_Matrix3x2.CreateRotation*benchmarks (#91361)