Merged
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsCloses #64935
|
Contributor
Author
|
Calculated based on #64935 (comment) and reworked from #64935 (comment). I used Notes for future users:
|
am11
reviewed
Sep 4, 2023
src/coreclr/pal/src/misc/sysinfo.cpp
Outdated
| if (lpBuffer->ullTotalPhys > 0) | ||
| { | ||
| #ifndef __APPLE__ | ||
| #if defined (__APPLE__) |
Member
There was a problem hiding this comment.
GlobalMemoryStatusEx in PAL is unused (outside of PAL tests); good candidate of deletion?
i.e. everything this query reports: git grep GlobalMemoryStatusEx ':/src/coreclr/pal'
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64935