Skip to content

Fix Item4 is missing in some ValueTuples' IStructuralEquatable.Equals #91461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

hamarb123
Copy link
Contributor

Fixes #91457

@ghost ghost added area-System.Runtime community-contribution Indicates that the PR has been added by a community member labels Sep 1, 2023
@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #91457

Author: hamarb123
Assignees: -
Labels:

area-System.Runtime

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub
Copy link
Member

@jeffhandley, we should backport this to release/8.0.

@EgorBo
Copy link
Member

EgorBo commented Sep 1, 2023

@jeffhandley, we should backport this to release/8.0.

It seems that it was introduced in net6.0 so do we need to backport it to 6.0 and 7.0 as well?

@jeffhandley
Copy link
Member

With the potential for data loss that could occur in customers' applications, I do think we should backport this to 6.0 and 7.0 too.

@jeffhandley jeffhandley merged commit 9bf6d02 into dotnet:main Sep 1, 2023
@jeffhandley
Copy link
Member

/backport to release/8.0
/backport to release/7.0-staging
/backport to release/6.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6052140869

@jeffhandley
Copy link
Member

/backport to release/7.0-staging

@jeffhandley
Copy link
Member

/backport to release/6.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/6052193377

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/6052195472

@jeffhandley
Copy link
Member

@dotnet/compat -- Do you have any compatibility concerns with the 6.0 and 7.0 backports of this functional fix? It's clearly a behavioral change for the better, but could there be any surprises for customers when the patch goes through?

@Junjun-zhao
Copy link
Member

Adding @marklio @PriyaPurkayastha for more comments.

Is this fix merged into the latest .NET 8 RC2 build? We conducted a test pass with the latest build dotnet-sdk-8.0.100-rc.2.23456.6, and no related issues were found till now.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item4 is missing in some ValueTuples' IStructuralEquatable.Equals
5 participants