Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable an assert in BigInteger #91158

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Re-enable an assert in BigInteger #91158

merged 1 commit into from
Sep 5, 2023

Conversation

Rob-Hague
Copy link
Contributor

This was fixed in #84792 and no longer repros. A regression test was added in that PR.

Closes #84991

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 26, 2023
@ghost
Copy link

ghost commented Aug 26, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This was fixed in #84792 and no longer repros. A regression test was added in that PR.

Closes #84991

Author: Rob-Hague
Assignees: -
Labels:

area-System.Numerics
Milestone: -

@stephentoub
Copy link
Member

Thanks

@stephentoub stephentoub merged commit 47ab18f into dotnet:main Sep 5, 2023
@Rob-Hague Rob-Hague deleted the bigintassert branch September 5, 2023 17:37
@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigInteger has a buggy assert
2 participants
@Rob-Hague @stephentoub