[wasm] Don't allocate jiterpreter AOT tables unless AOT was enabled at build time #90978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If RunAOTCompilation was not set according to config, don't allocate tables for jiterpreter AOT optimizations
kg
requested review from
radical,
lewing,
pavelsavara,
vargaz and
lambdageek
as code owners
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis PR flows the RunAOTCompilation MSBuild property through into the boot config, and only allocates the jiterpreter's AOT tables at startup if the property was set at build time.
|
maraf
reviewed
Aug 23, 2023
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs
Outdated
Show resolved
Hide resolved
pavelsavara
requested changes
Aug 23, 2023
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
Cleanup
pavelsavara
reviewed
Aug 23, 2023
maraf
reviewed
Aug 24, 2023
| @@ -409,6 +409,8 @@ | |||
| <_CmakeEnvironmentVariable Include="WASM_ENABLE_SIMD=0" Condition="'$(WasmEnableSIMD)' == 'false'" /> | |||
There was a problem hiding this comment.
@radical @radekdoulik Why do we have these conditions here? We never build runtime with these settings, aren't we?
pavelsavara
approved these changes
Aug 24, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR flows the RunAOTCompilation MSBuild property through into the boot config, and only allocates the jiterpreter's AOT tables at startup if the property was set at build time.
This should reduce the startup penalty from pre-allocating function table entries for non-AOT scenarios.
Related dotnet/aspnetcore#49909