Fix invalid PGO optimization path on Nuget cache containing spaces.

[c272]

Since CMD does not strip quotes from arguments passed in with quotes by default, if a Nuget package cache path containing a space is passed to build-runtime.cmd, it will pass it into an additional CMake argument with an additional set of quotes.

This causes string semantics to be disabled upon reaching the second opening quote, thus separating the cache path into two separate arguments incorrectly, resulting in the PGO data optimization pointing to an invalid path.

This patch fixes this issue by simply removing the redundant quotes when accepting the arguments in build-runtime.cmd.

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Since CMD does not strip quotes from arguments passed in with quotes by default, if a Nuget package cache path containing a space is passed to build-runtime.cmd, it will pass it into an additional CMake argument with an additional set of quotes.

This causes string semantics to be disabled upon reaching the second opening quote, thus separating the cache path into two separate arguments incorrectly, resulting in the PGO data optimization pointing to an invalid path.

This patch fixes this issue by simply removing the redundant quotes when accepting the arguments in build-runtime.cmd.

Author:	c272
Assignees:	-
Labels:	area-Infrastructure-coreclr, community-contribution
Milestone:	-

[a74nh]

We (Arm) saw this issue when doing testing directly on a Windows On Arm box.
I'm not familiar with .cmd syntax, but this patch fixes it for us.

[a74nh]

Looks like the (Build coreclr Pri0 Runtime Tests Run osx x64 checked) failures are nothing to do with this patch

[kunalspathak]

LGTM