Skip to content

[mono] Enable callconv and classloader runtime tests #90421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kotlarmilos
Copy link
Member

This PR enables callconv and classloader runtime tests in AOT mode.

Fixes #90280 (comment)

@ghost
Copy link

ghost commented Aug 11, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR enables callconv and classloader runtime tests in AOT mode.

Fixes #90280 (comment)

Author: kotlarmilos
Assignees: kotlarmilos, LeVladIonescu
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@kotlarmilos
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SamMonoRT
Copy link
Member

Please verify the logs to ensure enabled tests are running/passing without known failures.

Copy link
Contributor

@LeVladIonescu LeVladIonescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests successfully ran, failures look unrelated.

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Aug 14, 2023

The JIT/Directed testing group is a merged testing group which is optimized for Helix execution but isn't compatible with apple mobile targets. I've attempted to enable merged testing groups in this PR, and currently waiting for the CI.

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

@LeVladIonescu The runtime tests are using interpreter, so we can't confirm if the tests were executed successfully. I reopened the issue, which should be confirmed using apple mobile pipeline (once switched to full AOT mode) or full AOT linux pipeline.

This PR improves test coverage for apple mobile platforms and will be merged.

@kotlarmilos kotlarmilos merged commit 4e31eab into dotnet:main Aug 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants