Flow the IMeterFactory to SocketsHttpHandler on Mobile #90298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsI realized that what was actually happening here is that we weren't passing the You would end up with 2 separate meters:
The test that only listened to the metrics from one factory wouldn't see the
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Not seeing the failure mentioned in #90225 (comment) on Android runs anymore, so this seems to do the trick. |
This was referenced Aug 10, 2023
This was referenced Aug 11, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that what was actually happening here is that we weren't passing the
IMeterFactoryto theSocketsHttpHandlerin ourHttpClientHandler.AnyMobile.csimplementation.You would end up with 2 separate meters:
The test that only listened to the metrics from one factory wouldn't see the
SocketsHttpHandermetrics, which is why I thought we weren't using the correct handler in #90225.