Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Https_MultipleRequests_TlsResumed test Linux specific #90286

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 10, 2023

this is new test introduced in #88214. Since #75434 manifest only on Linux I make the test also Linux specific.
It should on Windows as well - I could not reproduce the failures - but .NET is not in charge of the TLS resume and it is not what the fix & test is trying to guard.

fixes #88979

@wfurt wfurt added area-System.Net.Security test-enhancement Improvements of test source code labels Aug 10, 2023
@wfurt wfurt added this to the 8.0.0 milestone Aug 10, 2023
@wfurt wfurt requested a review from MihaZupan August 10, 2023 00:33
@wfurt wfurt self-assigned this Aug 10, 2023
@ghost
Copy link

ghost commented Aug 10, 2023

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

this is new test introduced in #88214. Since #75434 manifest only on Linux I make the test also Linux specific.
It should on Windows as well - I could not reproduce the failures - but .NET is not in charge of the TLS resume and it is not what the fix & test is trying to guard.

fixes #88979

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, test-enhancement

Milestone: 8.0.0

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

It should on Windows as well - I could not reproduce the failures

If you ever want me to collect more info, whatever's different about my machine is making this consistently reproducible.

@stephentoub stephentoub merged commit 1b54c69 into dotnet:main Aug 10, 2023
103 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Https_MultipleRequests_TlsResumed test is unreliable
3 participants