Remove spurious assertion check causing .NET Core crashes #89986

trylek · 2023-08-04T00:38:24Z

I started this investigation based on heads-up from Rich Lander who hit the issue in a PR run. Thanks to help from Jan Vorlicek I have been able to repro the issue and I discussed it with Tanner Gooding who proposed this fix - removing the superfluous assertion check duplicating an upfront check in the method NarrowUtf16ToAscii before calling into the intrinsified version.

I sincerely admit I'm not an expert in the field of instruction set extensions and I have driven this investigation mostly because David Wrighton is OOF on parental leave for the entire month of August so I'm trying to make sure we ship .NET 8 in the best possible quality; I'll be more than happy for any suggestions for improvements or any other feedback.

Thanks

Tomas

/cc @dotnet/crossgen-contrib @davidwrighton @richlander

I started this investigation based on heads-up from Rich Lander who hit the issue in a PR run. Thanks to help from Jan Vorlicek I have been able to repro the issue and I discussed it with Tanner Gooding who proposed this fix - removing the superfluous assertion check duplicating an upfront check in the method NarrowUtf16ToAscii before calling into the intrinsified version. I sincerely admit I'm not an expert in the field of instruction set extensions and I have driven this investigation mostly because David Wrighton is OOF on parental leave for the entire month of August so I'm trying to make sure we ship .NET 8 in the best possible quality; I'll be more than happy for any suggestions for improvements or any other feedback. Thanks Tomas

ghost · 2023-08-04T00:38:38Z

Tagging subscribers to this area: @dotnet/area-system-text-encoding
See info in area-owners.md if you want to be subscribed.

Issue Details

I started this investigation based on heads-up from Rich Lander who hit the issue in a PR run. Thanks to help from Jan Vorlicek I have been able to repro the issue and I discussed it with Tanner Gooding who proposed this fix - removing the superfluous assertion check duplicating an upfront check in the method NarrowUtf16ToAscii before calling into the intrinsified version.

I sincerely admit I'm not an expert in the field of instruction set extensions and I have driven this investigation mostly because David Wrighton is OOF on parental leave for the entire month of August so I'm trying to make sure we ship .NET 8 in the best possible quality; I'll be more than happy for any suggestions for improvements or any other feedback.

Thanks

Tomas

/cc @dotnet/crossgen-contrib @davidwrighton @richlander

Author:	trylek
Assignees:	trylek
Labels:	`area-System.Text.Encoding`
Milestone:	-

jkotas · 2023-08-04T00:53:50Z

src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

@@ -2142,7 +2142,6 @@ private static unsafe nuint NarrowUtf16ToAscii_Intrinsified_256(char* pUtf16Buff
            // jumps as much as possible in the optimistic case of "all ASCII". If we see non-ASCII
            // data, we jump out of the hot paths to targets at the end of the method.

-            Debug.Assert(Vector256.IsHardwareAccelerated, "Vector256 is required.");


There are similar asserts in multiple other places, e.g. here:

runtime/src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

Line 2261 in bd0d278

Debug.Assert(Vector512.IsHardwareAccelerated, "Vector512 is required.");

. Do all of them have the same problem?

I'm curious about this as well.

Yes, they all theoretically have the same problem.

We "probably" want to eventually make these annotated as [CompExactlyDependsOn(typeof(Vector512))] (or similar), but the analyzer doesn't support the Vector128/256/512.IsHardwareAccelerated pattern today and that's significantly more involved.

Since the current code isn't "broken", it will just have worse perf than expected until these helpers get rejitted as well; the simpler fix of removing the assert is likely better for right now.

The general issue is that NarrowUtf16ToAscii was compiled under R2R and targeted V128. It hit 30 invocations, was rejitted, and now targets V256. However, NarrowToUtf16_Intrinsified_256 will now be hitting its first invocation. Since its not marked as compExactlyDependsOn it runs its R2R code and hits the assert.

I think, .NET Runtime currently have some bug inside morph.cpp. May be it's the same as previous which was fixed some years ago by dotnet/coreclr#15814
Could anybody from .NET team check my guess?

Could anybody view changes inside my branch bugfix/trying-to-fix-bug-with-build? I think it fix problem with current build (currently I check it). If so, I can create PR or somebody from .NET team can cherry pick my commit
FYI @ivdiazsa

@Maximys - I believe we intentionally removed the -O Crossgen2 option as it should be implied by assembly-level attributes set by the Roslyn compiler. Can you please be more specific as to what exactly is failing for you?

@trylek , I have next result of build.cmd run without -O Crossgen2:

C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Process terminated. Assertion failed. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCor e.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Vector256 is required. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.s fxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Ascii.NarrowUtf16ToAscii(Char* pUtf16Buffer, Byte* pAsciiBuffer, UIntPtr elementCount) [C:\r untime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8Utility.TranscodeToUtf8(Char* pInputBuffer, Int32 inputLength, Byte* pOutputBuff er, Int32 outputBytesRemaining, Char*& pInputBufferRemaining, Byte*& pOutputBufferRemaining) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8.FromUtf16(ReadOnlySpan`1 source, Span`1 destination, Int32& charsRead, Int32& b ytesWritten, Boolean replaceInvalidSequences, Boolean isFinalBlock) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.PrintFromUtf16(ReadOnlySpan`1 utf16, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1911 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.printClassName(CORINFO_CLASS_STRUCT_* cls, Byte* buffer, UIntPtr buffe rSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1975 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl._printClassName(IntPtr thisHandle, IntPtr* ppException, CORINFO_CLASS_ STRUCT_* cls, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl_generated.cs:line 547 [C:\runtime\src\installer\pkg\sfx\Microsoft.NE TCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethodInternal(IMethodNode methodCodeNodeNeedingCode, MethodIL methodIL) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 352 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethod(MethodWithGCInfo methodCodeNodeNeedingCode, Logger logge r) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\JitInterface\CorInfoImpl.ReadyToRun.cs:line 801 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOneMethod|5(DependencyNodeCore`1 dependency, Int32 compileThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 899 [C:\runtime\src\installer\pkg\s fx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOnThread|4(Int32 compilationThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 833 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micro soft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ilationThread|3(Object objThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 811 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft. NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Threading.Thread.StartCallback() [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsof t.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Process terminated. Assertion failed. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCor e.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Vector256 is required. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.s fxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Ascii.NarrowUtf16ToAscii(Char* pUtf16Buffer, Byte* pAsciiBuffer, UIntPtr elementCount) [C:\r untime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8Utility.TranscodeToUtf8(Char* pInputBuffer, Int32 inputLength, Byte* pOutputBuff er, Int32 outputBytesRemaining, Char*& pInputBufferRemaining, Byte*& pOutputBufferRemaining) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8.FromUtf16(ReadOnlySpan`1 source, Span`1 destination, Int32& charsRead, Int32& b ytesWritten, Boolean replaceInvalidSequences, Boolean isFinalBlock) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.PrintFromUtf16(ReadOnlySpan`1 utf16, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1911 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.printClassName(CORINFO_CLASS_STRUCT_* cls, Byte* buffer, UIntPtr buffe rSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1975 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl._printClassName(IntPtr thisHandle, IntPtr* ppException, CORINFO_CLASS_ STRUCT_* cls, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl_generated.cs:line 547 [C:\runtime\src\installer\pkg\sfx\Microsoft.NE TCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethodInternal(IMethodNode methodCodeNodeNeedingCode, MethodIL methodIL) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 352 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethod(MethodWithGCInfo methodCodeNodeNeedingCode, Logger logge r) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\JitInterface\CorInfoImpl.ReadyToRun.cs:line 801 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOneMethod|5(DependencyNodeCore`1 dependency, Int32 compileThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 899 [C:\runtime\src\installer\pkg\s fx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOnThread|4(Int32 compilationThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 833 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micro soft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileMethodList|2(IEnumerable`1 methodList) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 793 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micr osoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.ComputeDependencyNodeDependencies(List`1 obj) in C:\runtime\src\ coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 717 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeDependencies(List`1 deferredStaticDep endencies) in C:\runtime\src\coreclr\tools\aot\ILCompiler.DependencyAnalysisFramework\DependencyAnalyzer.cs:line 176 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj ] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeMarkedNodes() in C:\runtime\src\corec lr\tools\aot\ILCompiler.DependencyAnalysisFramework\DependencyAnalyzer.cs:line 316 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.Compile(String outputFile) in C:\runtime\src\coreclr\tools\aot\I LCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 387 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Program.RunSingleCompilation(Dictionary`2 inFilePaths, InstructionSetSupport instructionSetSu pport, String compositeRootPath, Dictionary`2 unrootedInputFilePaths, HashSet`1 versionBubbleModulesHash, ReadyToRunCompilerContext typeSystemContext, Logger logger) in C:\runtime\src\coreclr\tools\aot\crossgen 2\Program.cs:line 637 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Program.Run() in C:\runtime\src\coreclr\tools\aot\crossgen2\Program.cs:line 302 [C:\runtime\s rc\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Crossgen2RootCommand.<>c__DisplayClass205_0.<.ctor>b__0(ParseResult result) in C:\runtime\src \coreclr\tools\aot\crossgen2\Crossgen2RootCommand.cs:line 261 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.CommandLine.Invocation.InvocationPipeline.Invoke(ParseResult parseResult) [C:\runtime\src\install er\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Program.Main(String[] args) in C:\runtime\src\coreclr\tools\aot\crossgen2\Program.cs:line 914 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Process terminated. Assertion failed. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCor e.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Vector256 is required. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.s fxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Ascii.NarrowUtf16ToAscii(Char* pUtf16Buffer, Byte* pAsciiBuffer, UIntPtr elementCount) [C:\r untime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8Utility.TranscodeToUtf8(Char* pInputBuffer, Int32 inputLength, Byte* pOutputBuff er, Int32 outputBytesRemaining, Char*& pInputBufferRemaining, Byte*& pOutputBufferRemaining) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8.FromUtf16(ReadOnlySpan`1 source, Span`1 destination, Int32& charsRead, Int32& b ytesWritten, Boolean replaceInvalidSequences, Boolean isFinalBlock) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.PrintFromUtf16(ReadOnlySpan`1 utf16, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1911 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.printMethodName(CORINFO_METHOD_STRUCT_* ftn, Byte* buffer, UIntPtr buf ferSize, UIntPtr* requiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 3279 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl._printMethodName(IntPtr thisHandle, IntPtr* ppException, CORINFO_METHO D_STRUCT_* ftn, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl_generated.cs:line 1690 [C:\runtime\src\installer\pkg\sfx\Microsoft .NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethodInternal(IMethodNode methodCodeNodeNeedingCode, MethodIL methodIL) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 352 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethod(MethodWithGCInfo methodCodeNodeNeedingCode, Logger logge r) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\JitInterface\CorInfoImpl.ReadyToRun.cs:line 801 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOneMethod|5(DependencyNodeCore`1 dependency, Int32 compileThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 899 [C:\runtime\src\installer\pkg\s fx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOnThread|4(Int32 compilationThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 833 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micro soft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ilationThread|3(Object objThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 811 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft. NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Threading.Thread.StartCallback() [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsof t.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Process terminated. Assertion failed. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCor e.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Vector256 is required. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.s fxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Ascii.NarrowUtf16ToAscii(Char* pUtf16Buffer, Byte* pAsciiBuffer, UIntPtr elementCount) [C:\r untime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8Utility.TranscodeToUtf8(Char* pInputBuffer, Int32 inputLength, Byte* pOutputBuff er, Int32 outputBytesRemaining, Char*& pInputBufferRemaining, Byte*& pOutputBufferRemaining) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8.FromUtf16(ReadOnlySpan`1 source, Span`1 destination, Int32& charsRead, Int32& b ytesWritten, Boolean replaceInvalidSequences, Boolean isFinalBlock) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.PrintFromUtf16(ReadOnlySpan`1 utf16, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1911 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.printClassName(CORINFO_CLASS_STRUCT_* cls, Byte* buffer, UIntPtr buffe rSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1975 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl._printClassName(IntPtr thisHandle, IntPtr* ppException, CORINFO_CLASS_ STRUCT_* cls, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl_generated.cs:line 547 [C:\runtime\src\installer\pkg\sfx\Microsoft.NE TCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethodInternal(IMethodNode methodCodeNodeNeedingCode, MethodIL methodIL) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 352 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethod(MethodWithGCInfo methodCodeNodeNeedingCode, Logger logge r) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\JitInterface\CorInfoImpl.ReadyToRun.cs:line 801 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOneMethod|5(DependencyNodeCore`1 dependency, Int32 compileThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 899 [C:\runtime\src\installer\pkg\s fx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOnThread|4(Int32 compilationThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 833 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micro soft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileMethodList|2(IEnumerable`1 methodList) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 793 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micr osoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.ComputeDependencyNodeDependencies(List`1 obj) in C:\runtime\src\ coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 717 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeDependencies(List`1 deferredStaticDep endencies) in C:\runtime\src\coreclr\tools\aot\ILCompiler.DependencyAnalysisFramework\DependencyAnalyzer.cs:line 176 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj ] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeMarkedNodes() in C:\runtime\src\corec lr\tools\aot\ILCompiler.DependencyAnalysisFramework\DependencyAnalyzer.cs:line 316 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.Compile(String outputFile) in C:\runtime\src\coreclr\tools\aot\I LCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 387 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Program.RunSingleCompilation(Dictionary`2 inFilePaths, InstructionSetSupport instructionSetSu pport, String compositeRootPath, Dictionary`2 unrootedInputFilePaths, HashSet`1 versionBubbleModulesHash, ReadyToRunCompilerContext typeSystemContext, Logger logger) in C:\runtime\src\coreclr\tools\aot\crossgen 2\Program.cs:line 637 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Program.Run() in C:\runtime\src\coreclr\tools\aot\crossgen2\Program.cs:line 302 [C:\runtime\s rc\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Crossgen2RootCommand.<>c__DisplayClass205_0.<.ctor>b__0(ParseResult result) in C:\runtime\src \coreclr\tools\aot\crossgen2\Crossgen2RootCommand.cs:line 261 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.CommandLine.Invocation.InvocationPipeline.Invoke(ParseResult parseResult) [C:\runtime\src\install er\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.Program.Main(String[] args) in C:\runtime\src\coreclr\tools\aot\crossgen2\Program.cs:line 914 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Process terminated. Assertion failed. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCor e.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Vector256 is required. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.s fxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Ascii.NarrowUtf16ToAscii(Char* pUtf16Buffer, Byte* pAsciiBuffer, UIntPtr elementCount) [C:\r untime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8Utility.TranscodeToUtf8(Char* pInputBuffer, Int32 inputLength, Byte* pOutputBuff er, Int32 outputBytesRemaining, Char*& pInputBufferRemaining, Byte*& pOutputBufferRemaining) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8.FromUtf16(ReadOnlySpan`1 source, Span`1 destination, Int32& charsRead, Int32& b ytesWritten, Boolean replaceInvalidSequences, Boolean isFinalBlock) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.PrintFromUtf16(ReadOnlySpan`1 utf16, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1911 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.printClassName(CORINFO_CLASS_STRUCT_* cls, Byte* buffer, UIntPtr buffe rSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1975 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl._printClassName(IntPtr thisHandle, IntPtr* ppException, CORINFO_CLASS_ STRUCT_* cls, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl_generated.cs:line 547 [C:\runtime\src\installer\pkg\sfx\Microsoft.NE TCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethodInternal(IMethodNode methodCodeNodeNeedingCode, MethodIL methodIL) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 352 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethod(MethodWithGCInfo methodCodeNodeNeedingCode, Logger logge r) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\JitInterface\CorInfoImpl.ReadyToRun.cs:line 801 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOneMethod|5(DependencyNodeCore`1 dependency, Int32 compileThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 899 [C:\runtime\src\installer\pkg\s fx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOnThread|4(Int32 compilationThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 833 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micro soft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ilationThread|3(Object objThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 811 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft. NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Threading.Thread.StartCallback() [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsof t.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Process terminated. Assertion failed. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCor e.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Vector256 is required. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.s fxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Ascii.NarrowUtf16ToAscii(Char* pUtf16Buffer, Byte* pAsciiBuffer, UIntPtr elementCount) [C:\r untime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8Utility.TranscodeToUtf8(Char* pInputBuffer, Int32 inputLength, Byte* pOutputBuff er, Int32 outputBytesRemaining, Char*& pInputBufferRemaining, Byte*& pOutputBufferRemaining) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8.FromUtf16(ReadOnlySpan`1 source, Span`1 destination, Int32& charsRead, Int32& b ytesWritten, Boolean replaceInvalidSequences, Boolean isFinalBlock) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.PrintFromUtf16(ReadOnlySpan`1 utf16, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1911 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.printClassName(CORINFO_CLASS_STRUCT_* cls, Byte* buffer, UIntPtr buffe rSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1975 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl._printClassName(IntPtr thisHandle, IntPtr* ppException, CORINFO_CLASS_ STRUCT_* cls, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl_generated.cs:line 547 [C:\runtime\src\installer\pkg\sfx\Microsoft.NE TCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethodInternal(IMethodNode methodCodeNodeNeedingCode, MethodIL methodIL) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 352 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethod(MethodWithGCInfo methodCodeNodeNeedingCode, Logger logge r) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\JitInterface\CorInfoImpl.ReadyToRun.cs:line 801 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOneMethod|5(DependencyNodeCore`1 dependency, Int32 compileThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 899 [C:\runtime\src\installer\pkg\s fx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOnThread|4(Int32 compilationThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 833 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Mi8:36soft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ilationThread|3(Object objThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 811 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft. NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Threading.Thread.StartCallback() [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsof t.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Process terminated. Assertion failed. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCor e.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : Vector256 is required. [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.s fxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Ascii.NarrowUtf16ToAscii(Char* pUtf16Buffer, Byte* pAsciiBuffer, UIntPtr elementCount) [C:\r untime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8Utility.TranscodeToUtf8(Char* pInputBuffer, Int32 inputLength, Byte* pOutputBuff er, Int32 outputBytesRemaining, Char*& pInputBufferRemaining, Byte*& pOutputBufferRemaining) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Text.Unicode.Utf8.FromUtf16(ReadOnlySpan`1 source, Span`1 destination, Int32& charsRead, Int32& b ytesWritten, Boolean replaceInvalidSequences, Boolean isFinalBlock) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.PrintFromUtf16(ReadOnlySpan`1 utf16, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1911 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.printClassName(CORINFO_CLASS_STRUCT_* cls, Byte* buffer, UIntPtr buffe rSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 1975 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl._printClassName(IntPtr thisHandle, IntPtr* ppException, CORINFO_CLASS_ STRUCT_* cls, Byte* buffer, UIntPtr bufferSize, UIntPtr* pRequiredBufferSize) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl_generated.cs:line 547 [C:\runtime\src\installer\pkg\sfx\Microsoft.NE TCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.JitCompileMethod(IntPtr& exception, IntPtr jit, IntPtr thisHandle, Int Ptr callbacks, CORINFO_METHOD_INFO& info, UInt32 flags, IntPtr& nativeEntry, UInt32& codeSize) [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethodInternal(IMethodNode methodCodeNodeNeedingCode, MethodIL methodIL) in C:\runtime\src\coreclr\tools\Common\JitInterface\CorInfoImpl.cs:line 352 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at Internal.JitInterface.CorInfoImpl.CompileMethod(MethodWithGCInfo methodCodeNodeNeedingCode, Logger logge r) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\JitInterface\CorInfoImpl.ReadyToRun.cs:line 801 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOneMethod|5(DependencyNodeCore`1 dependency, Int32 compileThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 899 [C:\runtime\src\installer\pkg\s fx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ileOnThread|4(Int32 compilationThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 833 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Micro soft.NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at ILCompiler.ReadyToRunCodegenCompilation.<>c__DisplayClass50_0.<ComputeDependencyNodeDependencies>g__Comp ilationThread|3(Object objThreadId) in C:\runtime\src\coreclr\tools\aot\ILCompiler.ReadyToRun\Compiler\ReadyToRunCodegenCompilation.cs:line 811 [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft. NETCore.App.Runtime.sfxproj] C:\runtime\artifacts\bin\Crossgen2Tasks\Debug\net8.0\Microsoft.NET.CrossGen.targets(469,5): error : at System.Threading.Thread.StartCallback() [C:\runtime\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsof t.NETCore.App.Runtime.sfxproj]

richlander · 2023-08-04T01:01:52Z

Context: #86194 (comment)

jkotas · 2023-08-04T01:14:53Z

Context: #86194 (comment)

How is the error in this PR Unhandled exception. System.IO.FileNotFoundException: Could not find file '/datadisks/disk1/work/B4970A05/w/C0860A61/e/readytorun/determinism/crossgen2determinism/crossgen2smoke2.ildll'. that this referencing to connected to this assertion check?

trylek · 2023-08-04T02:19:56Z

I believe that the absence of the Crossgen2-compiled ildll file is due to the Crossgen2 crash caused by the assertion failure in question. Having said that, I sincerely admit I'm not clear on why we're not seeing the same "Vector256 is required" message in lab logs, in Richard's case the problematic job uses checked runtime build so I'd expect the assertion to be active. Other than that, according to Tanner's explanation part of the problem is that today Roslyn analyzers aren't smart enough to understand that the conditional block at line

runtime/src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

Line 1642 in b9c1129

    
           else if (Vector256.IsHardwareAccelerated && elementCount >= 2 * (uint)Vector256<byte>.Count)

does an upfront check for Vector256 support and so it complained when I tried to put the CompExactlyDependsOn(typeof(Avx2)) attribute on the intrinsified version of the method NarrowUtf16ToAscii_Intrinsified_256.

richlander · 2023-08-04T03:44:52Z

Seems strange that we're seeing crashes with vector code and also this comment: #86194 (comment)

To my understanding, we've had the following four OS + Hardware states this release (with the last being the current state of the PR):

Ubuntu 18.04 w/o AVX512
Ubuntu 18.04 w/ AVX512
Ubuntu 22.04 w/o AVX512
Ubuntu 22.04 w/ AVX512

The referenced comment above relates to the second to last state. Perhaps there is something about Ubuntu 22.04 we don't understand?

jkotas · 2023-08-04T04:21:13Z

The assert will be hit when the process runs a particular combination of tier1, tier0 and R2R code. The tiered compilation is non-deterministic and affected by exact timing, so it is plausible that the problem showed up suddenly as side-effect of switching to Ubuntu 22.04.

richlander · 2023-08-07T22:41:18Z

Can we make a decision on this, this week?

jakobbotsch · 2023-08-09T13:33:53Z

I hit the assert consistently on debug builds of coreclr. This was exposed by #89223 since that means we are now crossgenning SPC without optimizations when building debug (but I don't deny that the problem may be broader than this scenario). Disabling R2R images with DOTNET_ReadyToRun=0 works as a workaround.

AaronRobinsonMSFT · 2023-08-09T18:32:08Z

@trylek I'm going to modify this PR to be a commented out line rather than a removal. I am then going to file an issue and reference we need a real fix. This is impacting too many people to not mitigate ASAP.

src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

…lity.cs

src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

…lity.cs

AaronRobinsonMSFT · 2023-08-09T18:44:33Z

This is commenting out an assert rather than deleting it. The CI ran green when it was deleted so I am taking that as a confirmation that commenting it out is also okay.

AaronRobinsonMSFT · 2023-08-09T18:45:06Z

Can someone sign off on this so I can merge?

src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs

…lity.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas

Thank you!

trylek requested review from stephentoub and tannergooding August 4, 2023 00:38

ghost added the area-System.Text.Encoding label Aug 4, 2023

ghost assigned trylek Aug 4, 2023

jkotas reviewed Aug 4, 2023

View reviewed changes

AaronRobinsonMSFT reviewed Aug 9, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs Show resolved Hide resolved

Update src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Uti…

471781e

…lity.cs

AaronRobinsonMSFT reviewed Aug 9, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs Outdated Show resolved Hide resolved

Update src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Uti…

52ecaf2

…lity.cs

jkotas reviewed Aug 9, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs Show resolved Hide resolved

AaronRobinsonMSFT mentioned this pull request Aug 9, 2023

Vector256 assert is firing for crossgen'd SPCL #90265

Closed

Update src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Uti…

8b07817

…lity.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas approved these changes Aug 9, 2023

View reviewed changes

AaronRobinsonMSFT merged commit e7a9930 into dotnet:main Aug 9, 2023

richlander mentioned this pull request Aug 9, 2023

Upgrade all VMs to AMD64 Ubuntu 22.04 #86194

Merged

ivdiazsa mentioned this pull request Aug 9, 2023

Restore Crossgen2's Optimizations in CoreCLR Builds #90278

Merged

build-analysis bot mentioned this pull request Aug 10, 2023

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Open

trylek deleted the CG2Determinism branch September 5, 2023 19:29

ghost locked as resolved and limited conversation to collaborators Oct 6, 2023

Remove spurious assertion check causing .NET Core crashes #89986

Remove spurious assertion check causing .NET Core crashes #89986

Uh oh!

Conversation

trylek commented Aug 4, 2023

Uh oh!

ghost commented Aug 4, 2023

Uh oh!

jkotas Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

ivdiazsa Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

tannergooding Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

Maximys Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Maximys Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trylek Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

Maximys Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

richlander commented Aug 4, 2023

Uh oh!

jkotas commented Aug 4, 2023

Uh oh!

trylek commented Aug 4, 2023

Uh oh!

richlander commented Aug 4, 2023

Uh oh!

jkotas commented Aug 4, 2023

Uh oh!

richlander commented Aug 7, 2023

Uh oh!

jakobbotsch commented Aug 9, 2023

Uh oh!

AaronRobinsonMSFT commented Aug 9, 2023

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Aug 9, 2023

Uh oh!

AaronRobinsonMSFT commented Aug 9, 2023

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Maximys Aug 7, 2023 •

edited

Loading

Maximys Aug 8, 2023 •

edited

Loading