[wasm][wbt] Split WBT classes to speed up CI job execution. #89926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIcuSharding and BuildPublish on Blazor always take the longest. I split them more or less into equal test count per class (~20 in icu, ~10 in build publish).
|
ilonatommy
changed the title
…during the code review, the test content was not changed - fixing now.
radical
changed the title
Member
|
Thank you for doing this! I'm also planning an automated solution for this, but could take some time. |
radical
reviewed
Aug 3, 2023
radical
requested changes
Aug 3, 2023
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Looks great! Thank you for doing this!!
src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTestsFromWasmTemplate.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTestsFromBlazorTemplate.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-author-action
Member
|
Also, can you make sure that we are not running fewer tests after this? |
ghost
removed
the
needs-author-action
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
approved these changes
Aug 4, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IcuSharding and BuildPublish on Blazor always take the longest. I split them more or less into equal test count per class (~20 in icu, ~10 in build publish).
This PR changes the times on wbt linux CI when we split into BuldPublish and BuildPublishDefaultTemplate:
Build time: ~1,5min -> ~1,5min
Run time: ~53min -> ~45min
Original time values taken from build 20230802.154 with 495 301 tests.
It's fine but the BuildPublish is the only test that keeps running till the end, around 30th minute all the other wbt are done already, so trying the 3-file split approach:
each <10 tests.
Build time: ~1,5min -> ~1,5min
Run time: ~53min -> 53 min - it seems 3 files split did not work as expected, @radical, it might be an outliner
but in this situation it does not look worthy to merge the changes.build 20230804.3
Okay, on the re-run it's already fine, 35 min as expected.
On windows it changed ~60min -> 42 min.