Remove _NoLogging methods from VM

[jasper-d]

Removes all _NoLogging methods.

Fixes #89634

[jkotas]

I think that assert wouldn't be a problem except for GetClassWithPossibleAV. Also, GetClass_NoLogging has FORCEINLINE while GetClass has only inline. Not sure what the best course of action here is.

• Rename GetClass_NoLogging to GetClassWithPossibleAV
• Change GetClass to call it GetClassWithPossibleAV and assert that the result is non-null. Mark both with FORCEINLINE for a good measure.

[jasper-d]

• Rename GetClass_NoLogging to GetClassWithPossibleAV

@jkotas There is already GetClassWithPossibleAV but that has CANNOT_HAVE_CONTRACT:

runtime/src/coreclr/vm/methodtable.inl

Lines 63 to 68 in f6a66fa

	inline PTR_EEClass MethodTable::GetClassWithPossibleAV()
	{
	CANNOT_HAVE_CONTRACT;
	SUPPORTS_DAC;
	return GetClass_NoLogging();
	}

So rename GetClassWithPossibleAV to GetClassWithPossibleAVNoContract and GetClass_NoLogging to GetClassWithPossibleAV?

[jkotas]

I would delete the existing GetClassWithPossibleAV and move the comment from the existing GetClassWithPossibleAV to the renamed GetClass_NoLogging.

The extra CANNOT_HAVE_CONTRACT annotation in the existing GetClassWithPossibleAV is not important.

[jkotas]

Thank you!

[jasper-d]

Thank you for the help!