Add Info warning for int return values #89601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #89315 Not the happiest with the wording of the error, so any suggestions would be welcome. Also, I don't love the fact that it needs a MarshalAs attribute to be silenced. Maybe we could use a MSBuild property to silence them? Or should we let the user put the ID in their editorconfig?
|
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/Compiles.cs
Outdated
Show resolved
Hide resolved
...raries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/CompileFails.cs
Show resolved
Hide resolved
|
I've also opened up #89603 as it's in a similar space and is also a likely pit of failure for conversions. |
…ces/Strings.resx Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
…ces/Strings.resx Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
…eGenerator.Unit.Tests/CompileFails.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/GeneratorDiagnostics.cs
Outdated
Show resolved
Hide resolved
...aries/System.Runtime.InteropServices/tests/Common/Verifiers/CSharpSourceGeneratorVerifier.cs
Outdated
Show resolved
Hide resolved
...aries/System.Runtime.InteropServices/tests/Common/Verifiers/CSharpSourceGeneratorVerifier.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Aug 1, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89315 and #89603
Not the happiest with the wording of the error, so any suggestions would be welcome.
Also, I don't love the fact that it needs a MarshalAs attribute to be silenced. Maybe we could use a MSBuild property to silence them? Or should we let the user put the ID in their editorconfig?