Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
d23ebc8
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 27, 2023
e1b2e1c
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 27, 2023
10cd8b8
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 27, 2023
ce1767d
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
8232823
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
eea20f8
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
730aaea
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
6bde732
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
a5e1f5e
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
76578c6
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
6893aef
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
3cd2659
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
e4c686e
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 28, 2023
bbf2b75
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 29, 2023
a185d8b
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 31, 2023
7613d91
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 31, 2023
bb5ec03
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 31, 2023
eceaeb2
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 31, 2023
9cc69af
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 31, 2023
d51c094
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 31, 2023
c994897
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Jul 31, 2023
300b674
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 1, 2023
6c9c3bd
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 1, 2023
1ca1889
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 1, 2023
0bb2014
Resolving new warnings around InlineArray
tannergooding Aug 1, 2023
c26f6c1
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 1, 2023
8398652
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 1, 2023
b4f7a3e
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 1, 2023
0d44cc0
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 1, 2023
11eadc8
Update dependencies from https://github.com/dotnet/roslyn build 20230…
dotnet-maestro[bot] Aug 2, 2023
abfb7b4
Suppress the new SizeConst warning for the MetadataLoadContext sample…
tannergooding Aug 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -354,18 +354,18 @@
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>7333879999019e28e47f58879180cba54f5e1843</Sha>
</Dependency>
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.7.0-3.23373.1">
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.8.0-1.23401.10">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>7829f6b85177e96de89bc67f32b61d74ac590f5a</Sha>
<Sha>b3dc95ebc77bcdf064617c3c4a85d1da0ea911ac</Sha>
</Dependency>
<Dependency Name="Microsoft.CodeAnalysis" Version="4.7.0-3.23373.1">
<Dependency Name="Microsoft.CodeAnalysis" Version="4.8.0-1.23401.10">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>7829f6b85177e96de89bc67f32b61d74ac590f5a</Sha>
<Sha>b3dc95ebc77bcdf064617c3c4a85d1da0ea911ac</Sha>
<SourceBuild RepoName="roslyn" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23373.1">
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.8.0-1.23401.10">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>7829f6b85177e96de89bc67f32b61d74ac590f5a</Sha>
<Sha>b3dc95ebc77bcdf064617c3c4a85d1da0ea911ac</Sha>
</Dependency>
<Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0-beta1.23364.2">
<Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
Expand Down
6 changes: 3 additions & 3 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
Any tools that contribute to the design-time experience should use the MicrosoftCodeAnalysisVersion_LatestVS property above to ensure
they do not break the local dev experience.
-->
<MicrosoftCodeAnalysisCSharpVersion>4.7.0-3.23373.1</MicrosoftCodeAnalysisCSharpVersion>
<MicrosoftCodeAnalysisVersion>4.7.0-3.23373.1</MicrosoftCodeAnalysisVersion>
<MicrosoftNetCompilersToolsetVersion>4.7.0-3.23373.1</MicrosoftNetCompilersToolsetVersion>
<MicrosoftCodeAnalysisCSharpVersion>4.8.0-1.23401.10</MicrosoftCodeAnalysisCSharpVersion>
<MicrosoftCodeAnalysisVersion>4.8.0-1.23401.10</MicrosoftCodeAnalysisVersion>
<MicrosoftNetCompilersToolsetVersion>4.8.0-1.23401.10</MicrosoftNetCompilersToolsetVersion>
</PropertyGroup>
<!--
For source generator support we need to target multiple versions of Roslyn in order to be able to run on older versions of Roslyn.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,12 @@ internal ref struct StackAllocatedArguments
[InlineArray(MaxStackAllocArgCount)]
internal ref struct StackAllocatedByRefs
{
// We're intentionally taking advantage of the runtime functionality, even if the language functionality won't work
// CS9184: 'Inline arrays' language feature is not supported for inline array types with element field which is either a 'ref' field, or has type that is not valid as a type argument.

#pragma warning disable CS9184
internal ref byte _arg0;
#pragma warning restore CS9184
}
}
}
12 changes: 2 additions & 10 deletions src/libraries/System.Private.CoreLib/src/System/ParamsArray.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,31 +12,23 @@

namespace System
{
[InlineArray(Length)]
[InlineArray(2)]
internal struct TwoObjects
{
private const int Length = 2;
internal object? Arg0;

[UnscopedRef]
private ref object? this[int i] => ref Unsafe.Add(ref Arg0, i);

public TwoObjects(object? arg0, object? arg1)
{
this[0] = arg0;
this[1] = arg1;
}
}

[InlineArray(Length)]
[InlineArray(3)]
internal struct ThreeObjects
{
private const int Length = 3;
internal object? Arg0;

[UnscopedRef]
private ref object? this[int i] => ref Unsafe.Add(ref Arg0, i);

public ThreeObjects(object? arg0, object? arg1, object? arg2)
{
this[0] = arg0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,12 @@ internal ref struct StackAllocatedArgumentsWithCopyBack
[InlineArray(MaxStackAllocArgCount)]
internal ref struct StackAllocatedByRefs
{
// We're intentionally taking advantage of the runtime functionality, even if the language functionality won't work
// CS9184: 'Inline arrays' language feature is not supported for inline array types with element field which is either a 'ref' field, or has type that is not valid as a type argument.

#pragma warning disable CS9184
internal ref byte _arg0;
#pragma warning restore CS9184
}
#endif
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -377,14 +377,24 @@ public class MarshalAsHolders
[MarshalAs(UnmanagedType.IDispatch, IidParameterIndex = 42)]
public int F4;

// We are explicitly testing ByValArray without a SizeConst
// CS9125: Attribute parameter 'SizeConst' must be specified.

#pragma warning disable CS9125
[MarshalAs(UnmanagedType.ByValArray)]
public int F5;
#pragma warning restore CS9125

[MarshalAs(UnmanagedType.ByValArray, SizeConst = 5)]
public int F6;

// We are explicitly testing ByValArray without a SizeConst
// CS9125: Attribute parameter 'SizeConst' must be specified.

#pragma warning disable CS9125
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.FunctionPtr)]
public int F7;
#pragma warning restore CS9125

[MarshalAs(UnmanagedType.ByValArray, SizeConst = 87, ArraySubType = UnmanagedType.FunctionPtr)]
public int F8;
Expand Down