Skip to content

Remove illink test workaround for removed declaring type #89529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

Remove illink test workaround for removed declaring type #89529

merged 1 commit into from
Jul 27, 2023

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jul 26, 2023

The object model wouldn't preserve declaring typesin these cases because the warnings are produced for members that are removed. Fixing the testcases to preserve these members lets us remove this workaround.

@sbomer
Remove illink test workaround
cec1cac 
The object model wouldn't preserve declaring typesin these cases
because the warnings are produced for members that are removed.
Fixing the testcases to preserve these members lets us remove
this workaround.
@sbomer sbomer requested a review from vitek-karas July 26, 2023 21:09
@sbomer sbomer requested a review from marek-safar as a code owner July 26, 2023 21:09
@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners linkable-framework Issues associated with delivering a linker friendly framework labels Jul 26, 2023
@ghost ghost assigned sbomer Jul 26, 2023
@ghost
Copy link

ghost commented Jul 26, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

The object model wouldn't preserve declaring typesin these cases because the warnings are produced for members that are removed. Fixing the testcases to preserve these members lets us remove this workaround.

Author: sbomer
Assignees: -
Labels:

linkable-framework, needs-area-label
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Jul 27, 2023
Closed
1 task
@marek-safar marek-safar added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 27, 2023
@ghost
Copy link

ghost commented Jul 27, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

The object model wouldn't preserve declaring typesin these cases because the warnings are produced for members that are removed. Fixing the testcases to preserve these members lets us remove this workaround.

Author: sbomer
Assignees: sbomer
Labels:

linkable-framework, area-Tools-ILLink
Milestone: -

@marek-safar marek-safar merged commit 89030ce into dotnet:main Jul 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2023
@sbomer sbomer deleted the removeTrimmingTestWorkaround branch November 3, 2023 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@sbomer sbomer

Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbomer @vitek-karas @marek-safar