Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Inline TLS access for windows/x64 #89472

Merged
merged 64 commits into from
Jan 17, 2024
Merged

[NativeAOT] Inline TLS access for windows/x64 #89472

merged 64 commits into from
Jan 17, 2024

Commits on Jul 25, 2023

  1. wip

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    f1c5228 View commit details
    Browse the repository at this point in the history

  2. working model

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    91ee21f View commit details
    Browse the repository at this point in the history

  3. wip

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fe242f1 View commit details
    Browse the repository at this point in the history

  4. wip

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fcf00d2 View commit details
    Browse the repository at this point in the history

  5. working

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    f736b2c View commit details
    Browse the repository at this point in the history

  6. Add helper for tlsIndex

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6cd92f3 View commit details
    Browse the repository at this point in the history

  7. add methods in superpmi

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    87c3f25 View commit details
    Browse the repository at this point in the history

  8. revert some local changes

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fb364a0 View commit details
    Browse the repository at this point in the history

  9. misc fixes

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e9610c6 View commit details
    Browse the repository at this point in the history

  10. Stop emitting TLS access code for windows/x64

    @kunalspathak
    kunalspathak committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    86d01a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. fix linux build errors

    @kunalspathak
    kunalspathak committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    09eaeb4 View commit details
    Browse the repository at this point in the history

  2. Do not throw not implemented for windows/x64

    @kunalspathak
    kunalspathak committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    337c2f4 View commit details
    Browse the repository at this point in the history

  3. fix the problem where ThreadStaticBase helper was still getting invoked

    @kunalspathak
    kunalspathak committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1209465 View commit details
    Browse the repository at this point in the history

  4. Revert certain changes from JIT method

    @kunalspathak
    kunalspathak committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    85e1db6 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Introduce getThreadLocalStaticInfo_ReadyToRun()

    @kunalspathak
    kunalspathak committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    a3d3070 View commit details
    Browse the repository at this point in the history

  2. Consume getThreadLocalStaticInfo_ReadyToRun()

    @kunalspathak
    kunalspathak committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    800005d View commit details
    Browse the repository at this point in the history

  3. Remove getTlsRootInfo() and other methods

    @kunalspathak
    kunalspathak committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    4766211 View commit details
    Browse the repository at this point in the history

  4. Revert unneeded changes

    @kunalspathak
    kunalspathak committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    b9adff7 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. missing gtInitCldHnd initialization

    @kunalspathak
    kunalspathak committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    9ca78ae View commit details
    Browse the repository at this point in the history

  2. save target address

    @kunalspathak
    kunalspathak committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    b142d28 View commit details
    Browse the repository at this point in the history

  3. jit format

    @kunalspathak
    kunalspathak committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    79de728 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Merge remote-tracking branch 'origin/main' into tls_nativeaot_winx64

    @kunalspathak
    kunalspathak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    25482b9 View commit details
    Browse the repository at this point in the history

  2. run thunkgenerator

    @kunalspathak
    kunalspathak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    1fe8103 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. resolve merge conflicts

    @kunalspathak
    kunalspathak committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7c03b66 View commit details
    Browse the repository at this point in the history

  2. fix issues so the TLS is inlined

    @kunalspathak
    kunalspathak committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    07c839b View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Rename data structures from *_ReadyToRun to *_NativeAOT

    @kunalspathak
    kunalspathak committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    65ceeaa View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into working_tls_nativeaot… 

    …_winx64
    @kunalspathak
    kunalspathak committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8af0e6e View commit details
    Browse the repository at this point in the history

  3. jit format

    @kunalspathak
    kunalspathak committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    fc8e2b8 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. fix some unit test

    @kunalspathak
    kunalspathak committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    d7e7f9d View commit details
    Browse the repository at this point in the history

  2. fix a bug

    @kunalspathak
    kunalspathak committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b70ceeb View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. fix the weird jump problem

    @kunalspathak
    kunalspathak committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    f6552f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. use enclosing type cls handle for VN of static gc/non-gc helper

    @kunalspathak
    kunalspathak committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    57893d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. fix a bug of resetting the flag

    @kunalspathak
    kunalspathak committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    1537ecd View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. useEnclosingTypeOnly from runtime to determine if VN should optimize it

    @kunalspathak
    kunalspathak committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ab95bb9 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. do not use vnf, but only use useEnclosingTypeAsArg0

    @kunalspathak
    kunalspathak committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c9040a2 View commit details
    Browse the repository at this point in the history

  2. Use GT_COMMA to add GCStaticBase call next to TLS call

    @kunalspathak
    kunalspathak committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5f76a6c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'kp/vn_staticbase' into working_tls_nati… 

    …veaot_winx64
    @kunalspathak
    kunalspathak committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    3d16881 View commit details
    Browse the repository at this point in the history

  4. optimize the cctor call

    @kunalspathak
    kunalspathak committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    daca626 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Remove lazy ctor generation from tls

    @kunalspathak
    kunalspathak committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c7d75ef View commit details
    Browse the repository at this point in the history

  2. Update jitinterface to not fetch data for lazy ctor

    @kunalspathak
    kunalspathak committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    5895ab3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into working_tls_nativeaot… 

    …_winx64
    @kunalspathak
    kunalspathak committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d53f324 View commit details
    Browse the repository at this point in the history

  4. fix errors after merge

    @kunalspathak
    kunalspathak committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    571b6df View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. fix test build errors

    @kunalspathak
    kunalspathak committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    da95659 View commit details
    Browse the repository at this point in the history

  2. fix bug in CSE

    @kunalspathak
    kunalspathak committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8679e4b View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Use CORINFO_FLG_FIELD_INITCLASS instead of separate flag

    @kunalspathak
    kunalspathak committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0ce7618 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Use the INITCLASS flag

    @kunalspathak
    kunalspathak committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b38a17c View commit details
    Browse the repository at this point in the history

  2. Remove useEnclosingTypeOnly

    @kunalspathak
    kunalspathak committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1c1092d View commit details
    Browse the repository at this point in the history

  3. Add NoCtor

    @kunalspathak
    kunalspathak committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    119e2ae View commit details
    Browse the repository at this point in the history

  4. Use CORINFO_HELP_READYTORUN_THREADSTATIC_BASE_NOCTOR

    @kunalspathak
    kunalspathak committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    9cfea39 View commit details
    Browse the repository at this point in the history

  5. Minor cleanup

    @kunalspathak
    kunalspathak committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    2cc3ca1 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Merge remote-tracking branch 'origin/main' into tls_nativeaot_winx64

    @kunalspathak
    kunalspathak committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8389a88 View commit details
    Browse the repository at this point in the history

  2. Renegenrate thunk

    @kunalspathak
    kunalspathak committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    59085d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Add the SetFalseTarget

    @kunalspathak
    kunalspathak committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fa1059f View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge remote-tracking branch 'origin/main' into tls_nativeaot_winx64

    @kunalspathak
    kunalspathak committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    63c9fd6 View commit details
    Browse the repository at this point in the history

  2. fix merge conflict resolution

    @kunalspathak
    kunalspathak committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    0069167 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. better handling of GTF_ICON_SECREL_OFFSET 

    better handling of GTF_ICON_SECREL_OFFSET
    @kunalspathak
    kunalspathak committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    38bca3b View commit details
    Browse the repository at this point in the history

  2. review feedback

    @kunalspathak
    kunalspathak committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a5fcc59 View commit details
    Browse the repository at this point in the history

  3. Disable optimization for minopts

    @kunalspathak
    kunalspathak committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ceda478 View commit details
    Browse the repository at this point in the history

  4. Add comments around iiaSecRel

    @kunalspathak
    kunalspathak committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    aba00e2 View commit details
    Browse the repository at this point in the history

  5. jit format

    @kunalspathak
    kunalspathak committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    24f88a0 View commit details
    Browse the repository at this point in the history

  6. create emitNewInstrCns()

    @kunalspathak
    kunalspathak committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    65f3900 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Expand TLS even if optimization is disabled

    @kunalspathak
    kunalspathak committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    5bc0a1a View commit details
    Browse the repository at this point in the history

  2. Track t_inlinedThreadStaticBase 

    Better tracking `t_inlinedThreadStaticBase` as TYP_REF
    @kunalspathak
    kunalspathak committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    959869a View commit details
    Browse the repository at this point in the history

  3. jit format

    @kunalspathak
    kunalspathak committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    bff4728 View commit details
    Browse the repository at this point in the history