Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Fix for EventPipe ep_rt_temp_path_get off by 1 issue. #89438

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

lateralusX
Copy link
Member

Fixes #86640

Fix includes a new native EventPipe test covering usage of ep_rt_temp_path_get function. Fix also include some build fixes for the native EventPipe test runner since its currently not build as part of CI.

@lateralusX
Copy link
Member Author

@davmason, @LakshanF possible to get a review so we can get this merged?

Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lateralusX lateralusX merged commit e40303b into dotnet:main Jul 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono EventPipe code in ep_rt_temp_path_get has an off by 1 issue
2 participants