-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Do not set -msimd128 in the default rsp #89433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first part of changes to make wasm/SIMD optional again, dotnet#89302
radekdoulik
requested review from
radical,
kg and
pavelsavara
and removed request for
kg
July 25, 2023 12:21
ghost
assigned radekdoulik
Jul 25, 2023
counts of the SIMD instructions in the bench sample (aot) to check the changes. the remaining instructions come from mono runtime libs and will be handled in separate PR
|
Please also make it to trigger
Also please do it for |
kg
approved these changes
Jul 25, 2023
radical
reviewed
Jul 25, 2023
pavelsavara
approved these changes
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of changes to make wasm/SIMD optional again, #89302
The
WASM_OPT_ADDITIONAL_FLAGS
is not used anymore, so remove it.Force relink when disabling SIMD or EH.