Skip to content

[browser] only trace ExitStatus stack trace if diagnosticTracing is true #89432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2023
Merged

[browser] only trace ExitStatus stack trace if diagnosticTracing is true #89432

merged 4 commits into from
Jul 25, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 25, 2023 •
edited
Loading

  • logErrorOnExit - only trace ExitStatus stack trace if diagnosticTracing is true
  • logErrorOnExit - reoder conditions
  • mono_wasm_stringify_as_error_with_stack to accept objects with stack, not just errors

@pavelsavara
- mono_wasm_stringify_as_error_with_stack to accept objects with stac…
d722359 
…k, not just errors

- logErrorOnExit - to not log ExitStatus stack trace
- logErrorOnExit - reoder conditions
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jul 25, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 25, 2023
@pavelsavara pavelsavara requested review from radical and maraf July 25, 2023 11:38
@pavelsavara pavelsavara requested a review from lewing as a code owner July 25, 2023 11:38
@pavelsavara pavelsavara self-assigned this Jul 25, 2023
@pavelsavara pavelsavara requested a review from kg as a code owner July 25, 2023 11:38
@ghost
Copy link

ghost commented Jul 25, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • mono_wasm_stringify_as_error_with_stack to accept objects with stack, not just errors
  • logErrorOnExit - to not log ExitStatus stack trace
  • logErrorOnExit - reoder conditions
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 8.0.0

@pavelsavara pavelsavara changed the title [browser] do not log ExitStatus stack trace [browser] only trace ExitStatus stack trace if diagnosticTracing is true Jul 25, 2023
ilonatommy
ilonatommy approved these changes Jul 25, 2023
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Jul 25, 2023
Closed
1 task
@radical
Copy link
Member

radical commented Jul 25, 2023

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-89432-merge-a8ac0ef18fcd43e985/Workloads-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/1/console.e73b5edf.log?helixlogtype=result :

        [warning] MONO_WASM: Failed to invoke 'onRuntimeConfigLoaded' on library initializer '../WasmBasicTestApp.lib.module.js': Error: Error thrown from library initializer
        [warning] MONO_WASM: mono_exit failed TypeError: Right-hand side of 'instanceof' is not an object
            at http://127.0.0.1:34325/_framework/dotnet.js:3:10699
            at H (http://127.0.0.1:34325/_framework/dotnet.js:3:11035)
            at I (http://127.0.0.1:34325/_framework/dotnet.js:3:8953)
            at T (http://127.0.0.1:34325/_framework/dotnet.js:3:8770)
            at async http://127.0.0.1:34325/_framework/dotnet.js:3:26506
            at async http://127.0.0.1:34325/_framework/dotnet.js:3:25747
            at async Object.create (http://127.0.0.1:34325/_framework/dotnet.js:3:32805)
            at async http://127.0.0.1:34325/main.js:61:53

@pavelsavara pavelsavara merged commit 6269d2b into dotnet:main Jul 25, 2023
This was referenced Jul 25, 2023
Closed
Open
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
@pavelsavara pavelsavara deleted the browser_silent_ExitStatus branch September 2, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@radekdoulik radekdoulik radekdoulik approved these changes

@maraf maraf maraf approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelsavara @radical @radekdoulik @maraf @ilonatommy