-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Remove InstructionSet_VectorT256 if AVX2 is disabled via env var #89413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is it something that I have somehow regressed by #89342 or was this a pre-existing bug? |
Probably, although, the issue reproduces only on CLR (NAOT and R2R are fine) and only if the cpu physically supports AVX2 but it's disabled by the config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to have a test checking Vector<T>.IsHardwareAccelerated
as well. I'm guessing we're missing that in CpuId.cs
and are only checking the size instead
Thank you for fixing it! |
|
Fixes #89408