Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move full facade assemblies into src/libraries/shims #89184

Merged
merged 6 commits into from
Jul 21, 2023

Commits on Jul 19, 2023

  1. Move full facade assemblies into src/libraries/shims

    Fixes #78978
    
    1. Move all full facade assemblies (which only contain type forwards)
       into src/libraries/shims.
    2. Merge assemblies (ref+src) which typeforward to the same
       destination.
    3. They inherently now don't produce a documentation file anymore (as
       shims only contain type forwards).
    
    This minimizes the build graph (makes the libs build faster) and moves
    the focus away from full facade assemblies that need to be kept for
    compat reasons.
    ViktorHofer committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    261c760 View commit details
    Browse the repository at this point in the history
  2. Trigger CI for all legs

    ViktorHofer committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5e746ce View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    8c20c81 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. PR feedback from Eric

    ViktorHofer committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bf300ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08f1468 View commit details
    Browse the repository at this point in the history
  3. Collapse ref and src shims further

    As discussed with Eric offline, typeforwarding to System.Runtime and
    System.Xml.ReaderWriter makes it possible to collapse the following
    ref and src projects into just src:
    
    System.AppContext
    System.Buffers
    System.Diagnostics.Debug
    System.Diagnostics.Tools
    System.Globalization
    System.Globalization.Calendars
    System.IO.UnmanagedMemoryStream
    System.Reflection
    System.Resources.ResourceManager
    System.Runtime.CompilerServices.Unsafe
    System.Runtime.Extensions
    System.Security.Principal
    System.Text.Encoding
    System.Threading.Timer
    System.Xml.XmlDocument
    
    The destination then handles the type fowarding to the private assembly
    implementation.
    ViktorHofer committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    912e897 View commit details
    Browse the repository at this point in the history