JIT: Clamp basic block IL ranges when splitting blocks #89179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In release, code motion/compaction may lead to statements ending up in blocks that don't contain their IL offset. This can cause splitting of blocks to create meaningless IL ranges such as [057..020). Since we maintain these IL ranges on a best-effort basis, just clamp them when we do the splitting. Fix dotnet#88348
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn release, code motion/compaction may lead to statements ending up in blocks that don't contain their IL offset. This can cause splitting of blocks to create meaningless IL ranges such as [057..020). Since we maintain these IL ranges on a best-effort basis, just clamp them when we do the splitting. Fix #88348
|
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
cc @dotnet/jit-contrib PTAL @EgorBo No diffs. |
BruceForstall
approved these changes
Jul 19, 2023
EgorBo
approved these changes
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release, code motion/compaction may lead to statements ending up in blocks that don't contain their IL offset. This can cause splitting of blocks to create meaningless IL ranges such as [057..020). Since we maintain these IL ranges on a best-effort basis, just clamp them when we do the splitting.
Fix #88348