Fix failures around blittable collections with [Out] and chars #89149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
jtschuster and
elinor-fung
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #88708
|
ghost
assigned
jtschuster
approved these changes
Jul 19, 2023
jtschuster
reviewed
Jul 19, 2023
| @@ -124,7 +128,8 @@ public IEnumerable<StatementSyntax> Generate(TypePositionInfo info, StubCodeCont | |||
|
|
|||
| public bool UsesNativeIdentifier(TypePositionInfo info, StubCodeContext context) | |||
| { | |||
| return context.IsInStubReturnPosition(info) || (info.IsByRef && !context.SingleFrameSpansNativeContext); | |||
| MarshalDirection elementMarshalDirection = MarshallerHelpers.GetMarshalDirection(info, context); | |||
| return !IsPinningPathSupported(info, context) && (elementMarshalDirection != MarshalDirection.ManagedToUnmanaged || info.IsByRef); | |||
There was a problem hiding this comment.
Nit: I find it easier to reason about when can we pass the managed identifier to a native parameter without changing anything, and then this method is not that, but I'm also fine with whatever makes the most sense to you.
Suggested change
| return !IsPinningPathSupported(info, context) && (elementMarshalDirection != MarshalDirection.ManagedToUnmanaged || info.IsByRef); | |
| return !(IsPinningPathSupported(info, context) || (elementMarshalDirection == MarshalDirection.UnmanagedToManaged && !info.IsByRef)); |
There was a problem hiding this comment.
I'd rather keep it as is as the current condition better matches the code in Generate I think.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88708