-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[wasm][debugger] Check client version to send debugger message #89025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…id incompatibility
Tagging subscribers to this area: @thaystg Issue DetailsChecking that BrowserDebugProxy is waiting for this new format to avoid incompatibility
|
Could you please explain what was the issue here? And how it is being fixed? |
Runtime has a newer version and BrowserDebugProxy is older, then runtime was sending a different message format and BrowserDebugProxy was crashing. |
Could you please add that to the PR description? |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsPR #86982 changed the response format for the But the PR missed adding appropriate version checks for the new format to keep backward compatibility. And this broke when a older proxy which didn't understand the new format was used with the updated runtime.
With this change I'm adding the needed version guards when sending the response. And bumping the BrowserDebugProxy version, so it can correctly get the newer format response. Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/2236
|
PR #86982 changed the response format for the
MDBGPROT_CMD_GET_ASSEMBLY_BYTES
in thedebugger-agent
, to send only the asm metadata instead of the full assembly contents.But the PR missed adding appropriate version checks for the new format to keep backward compatibility. And this broke when a older proxy which didn't understand the new format was used with the updated runtime.
With this change I'm adding the needed version guards when sending the response. And bumping the BrowserDebugProxy version, so it can correctly get the newer format response.
Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/2236