Use live illink for trimming tests #88929
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
|
I suggest running |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/tools/illink/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj
Outdated
Show resolved
Hide resolved
| <!-- Place build output into a layout that matches the package layout. --> | ||
| <OutputPath>$(OutputPath)/tools</OutputPath> |
There was a problem hiding this comment.
The build and package output paths are intentionally not aligned. Why do you need the tools subdirectory for the output path?
There was a problem hiding this comment.
I'm trying to set it up so that the tests can just import Microsoft.NET.ILLink.Tasks.props directly from the build output path, and have this logic work without further overrides:
Let me know if you'd prefer another approach.
There was a problem hiding this comment.
We should keep the output path and package layout separate, otherwise we will hit other issues over time. Please revert the OutputPath change.
There was a problem hiding this comment.
I reverted this change. It unfortunately means using live illink isn't as simple as a single import statement. I'm curious if you have specific concerns over the approach of matching the package layout in the output?
- Move props import to top of project file - Leave IsGeneratorProject in Directory.Build.props Ignore Directory.Build.props in Content
TFM isn't set during GenerateNuspec, but we need Content to be defined so that the props/targets get added to the package.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #88624