Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIMD node DOT retType #88363

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix SIMD node DOT retType #88363

merged 2 commits into from
Jul 5, 2023

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Jul 4, 2023 •
edited
Loading

We create Dot intrinsic nodes having float as well as TYP_SIMD12 return type, depending on the usage, but VN doesn't differentiate between such nodes and falsely give them same VN, which results into the result getting CSEd.

Contributes to #83316

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 4, 2023
@ghost ghost assigned kunalspathak Jul 4, 2023
@ghost
Copy link

ghost commented Jul 4, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak
Copy link
Member Author

@tannergooding

@kunalspathak kunalspathak marked this pull request as ready for review July 5, 2023 15:07
tannergooding
tannergooding approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noting this should be sufficient to resolve the known test failure but not sufficient to resolve all possible failures.

If you want to get this merged and then assign the issue to me, I can resolve the remaining issues.

@kunalspathak kunalspathak merged commit f11edcd into dotnet:main Jul 5, 2023
@kunalspathak kunalspathak deleted the issue_83316 branch July 5, 2023 17:05
@ghost ghost locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunalspathak @tannergooding