Fix Out of memory with source gen tests #88266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Related: #87934 |
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@CyrusNajmabadi could you please have a look? CC @jaredpar |
CyrusNajmabadi
approved these changes
Jun 30, 2023
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsFixes #87934
|
jkotas
added
source-generator
|
The unrelated failure in the jitstress is tracked by #88224 |
| @@ -215,7 +228,8 @@ public static TextSpan MakeSpan(string text, int spanNum) | |||
| string? defaultNamespace = null, | |||
| string? extraFile = null) | |||
| { | |||
| Project proj = CreateTestProject(references); | |||
| using var workspace = CreateTestWorkspace(); | |||
There was a problem hiding this comment.
For my education, OOM's were triggered by AdhocWorkspace instances not being disposed?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87934