Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify substitutions externally #88230

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

MichalStrehovsky
Copy link
Member

ILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well.

Cc @dotnet/ilc-contrib

ILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well.
@ghost
Copy link

ghost commented Jun 30, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

ILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

There are some illink tests which are currently disabled for NativeAOT because of this. I think it should be possible to reenable them (with some more infra work):
https://github.com/dotnet/runtime/blob/main/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/CanWarnAsError.cs

Feel free to create an issue for that and link it to #82447. Doesn't have to be done now or as part of this PR.

@MichalStrehovsky
Copy link
Member Author

The changes look good.

There are some illink tests which are currently disabled for NativeAOT because of this. I think it should be possible to reenable them (with some more infra work): https://github.com/dotnet/runtime/blob/main/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/CanWarnAsError.cs

Feel free to create an issue for that and link it to #82447. Doesn't have to be done now or as part of this PR.

Thanks! Opened #88647 and linked from the uber issue.

@MichalStrehovsky MichalStrehovsky merged commit 076f8c5 into dotnet:main Jul 11, 2023
@MichalStrehovsky MichalStrehovsky deleted the externalxml branch July 11, 2023 04:50
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants