Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to the forwarder generator for invalid [In, Out] attributes instead of using the already-selected generator with additional diagnostics #88055

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

jkoritzinsky
Copy link
Member

Fixes #87999

… instead of using the already-selected generator with additional diagnostics.
@ghost
Copy link

ghost commented Jun 26, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #87999

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: -

@jkoritzinsky jkoritzinsky added the source-generator Indicates an issue with a source generator feature label Jun 26, 2023
@AaronRobinsonMSFT
Copy link
Member

Did we miss this because we don't run these tests on mono in the CI?

@jkoritzinsky
Copy link
Member Author

Did we miss this because we don't run these tests on mono in the CI?

We missed this because we don't run outerloop tests in CI by default, and getting outerloop tests to run locally is annoying and I missed this in my last runs before the diagnostic refactor.

@am11
Copy link
Member

am11 commented Jun 26, 2023

Did we miss this because we don't run these tests on mono in the CI?

I was looking around various CI pipelines after 2f2aaae was merged, to see if it has caused any regression. Noticed that this test started failing in an outerloop leg runtime-libraries-coreclr outerloop-linux the same day my PR was merged and narrowed it down to 73f96e6. Unfortunately, the failing leg runtime-libraries-coreclr outerloop-linux is red for other reasons (even before Jun 22) so it is easy to miss had that outerloop pipeline ran with @jkoritzinsky's previous PR. (perhaps build analysis could've caught this new failure? not sure)

Thanks for the quick fix! 8-)

@jkoritzinsky
Copy link
Member Author

Failures are unrelated

@jkoritzinsky jkoritzinsky merged commit 5e71921 into dotnet:main Jun 26, 2023
@jkoritzinsky jkoritzinsky deleted the fix-outerloop branch June 26, 2023 20:18
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibraryImportGenerator outerloop test failure
4 participants