-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relaxing IsConnected Check for Datagram Sockets #87916
Merged
liveans
merged 8 commits into
dotnet:main
from
liveans:relax-is-connected-check-for-datagram
Jul 17, 2023
Merged
Relaxing IsConnected Check for Datagram Sockets #87916
liveans
merged 8 commits into
dotnet:main
from
liveans:relax-is-connected-check-for-datagram
Jul 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #77962
|
Looks like this was introduced as part of another bug fix in dotnet/corefx#27173 |
stephentoub
reviewed
Jun 22, 2023
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 28, 2023
Closed
antonfirsov
reviewed
Jun 28, 2023
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
Outdated
Show resolved
Hide resolved
antonfirsov
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77962
.NET Framework's behavior may be different for
SocketType.Stream
, but this PR will match the behavior for other socket types.According to linux connect man page
According to WinSock2 connect api
According to OSX connect man page: