[mono][simd] Add MONO_TYPE_I and MONO_TYPE_U types for OP_NEGATION on amd64 #87607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BrzVlad
reviewed
Jun 15, 2023
|
Why isn't this problem hit by the normal desktop test suites ? |
|
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
approved these changes
Jun 15, 2023
|
The failures are known and the issue has been fixed. |
This was referenced Jun 15, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mono functional tests are failing during AOT compilation on iossimulator/tvossimulator. It appears that there is an issue with decoding the ins->inst_c1 type in OP_NEGATION. Assumption is that the MONO_TYPE_I and MONO_TYPE_U types for OP_NEGATION on amd64 are missing.
Fixes #87606
This PR should verify whether the change resolves the issue causing the CI failures.
/cc: @vargaz @jandupej